Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET SDK to 10.0.100-preview.3.25122.1 #60564

Merged
merged 10 commits into from
Mar 11, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Updates the .NET SDK to version 10.0.100-preview.3.25122.1, which also updates the .NET runtime from version 10.0.0-preview.2.25109.2 to version 10.0.0-preview.2.25119.7.

This pull request was auto-generated by GitHub Actions.

Update .NET SDK to version 10.0.100-preview.3.25122.1.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot requested review from wtgodbe and a team as code owners February 23, 2025 13:40
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 23, 2025
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving SDK update.

@akoeplinger
Copy link
Member

D:\a_work\1\s\src\Servers\IIS\AspNetCoreModuleV2\CommonLib\HostFxrResolver.cpp(17,10): error C1083: Cannot open include file: 'nethost.h': No such file or directory

we try to take it from the downloaded sdk:

<!-- This is not correct and needs attention eventually. This is primarily used to find the nethost headers in the apphost pack.
These should be coming from a restored apphost pack, rather than a hard-coded local SDK. In fact, aspnetcore
should not rely on a local SDK or mutating one to build. -->
<NetCoreTargetingPackRoot Condition="'$(DotNetBuild)' == 'true'">$(DotNetRoot)packs\</NetCoreTargetingPackRoot>

I confirmed that the sdk no longer contains the x86/arm64 apphost packs.

@ViktorHofer I think this is more fallout from your recent changes.

image

@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 24, 2025

This difference is expected as we removed the cross-apphosts from the layout: dotnet/sdk#46911. They are getting installed via the bundles. We will need to update aspnetcore to acquire them differently.

@ViktorHofer ViktorHofer self-assigned this Feb 24, 2025
@ViktorHofer
Copy link
Member

I will take another look later this week. Let me know if merging this change in becomes more urgent.

Copy link
Contributor Author

github-actions bot commented Mar 3, 2025

Superseded by #60713.

@github-actions github-actions bot closed this Mar 3, 2025
@github-actions github-actions bot deleted the update-dotnet-sdk-10.0.100-preview.3.25122.1 branch March 3, 2025 12:12
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview3 milestone Mar 3, 2025
@ViktorHofer ViktorHofer restored the update-dotnet-sdk-10.0.100-preview.3.25122.1 branch March 5, 2025 11:44
@ViktorHofer ViktorHofer reopened this Mar 5, 2025
Copy link
Contributor Author

Superseded by #60845.

@github-actions github-actions bot closed this Mar 10, 2025
@github-actions github-actions bot deleted the update-dotnet-sdk-10.0.100-preview.3.25122.1 branch March 10, 2025 12:13
@ViktorHofer ViktorHofer restored the update-dotnet-sdk-10.0.100-preview.3.25122.1 branch March 10, 2025 12:28
@ViktorHofer ViktorHofer reopened this Mar 10, 2025
<!-- This tools version MUST match the same version as runtime uses to compile libnethost.lib -->
<PlatformToolsetVersion>143</PlatformToolsetVersion>
</PropertyGroup>

<!-- Platform is different during restore than during build. Therefore, restore everything when not building the product. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkoritzinsky you might have some ideas how to fix this properly? (for a follow-up)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restoring everything doesn't sound that bad to me either, curious why you didn't use PackageDownload?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restoring everything doesn't sound that bad to me either

It creates an artificial difference between the VMR and the repo build. But not the end of the world, for sure.

curious why you didn't use PackageDownload?

vcxproj restore (opt in via EnableManagedPackageReferenceSupport) doesn't support PackageDownload.

@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 11, 2025

This one is finally ready :)

@ViktorHofer ViktorHofer enabled auto-merge (squash) March 11, 2025 17:17
@ViktorHofer ViktorHofer merged commit bac31da into main Mar 11, 2025
27 checks passed
@ViktorHofer ViktorHofer deleted the update-dotnet-sdk-10.0.100-preview.3.25122.1 branch March 11, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants