-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .NET SDK to 10.0.100-preview.3.25122.1 #60564
Update .NET SDK to 10.0.100-preview.3.25122.1 #60564
Conversation
Update .NET SDK to version 10.0.100-preview.3.25122.1. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approving SDK update.
(cherry picked from commit ab38a29)
we try to take it from the downloaded sdk: aspnetcore/Directory.Build.props Lines 205 to 208 in 4aa5bcc
I confirmed that the sdk no longer contains the x86/arm64 apphost packs. @ViktorHofer I think this is more fallout from your recent changes. ![]() |
This difference is expected as we removed the cross-apphosts from the layout: dotnet/sdk#46911. They are getting installed via the bundles. We will need to update aspnetcore to acquire them differently. |
I will take another look later this week. Let me know if merging this change in becomes more urgent. |
Superseded by #60713. |
Superseded by #60845. |
<!-- This tools version MUST match the same version as runtime uses to compile libnethost.lib --> | ||
<PlatformToolsetVersion>143</PlatformToolsetVersion> | ||
</PropertyGroup> | ||
|
||
<!-- Platform is different during restore than during build. Therefore, restore everything when not building the product. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkoritzinsky you might have some ideas how to fix this properly? (for a follow-up)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restoring everything doesn't sound that bad to me either, curious why you didn't use PackageDownload?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restoring everything doesn't sound that bad to me either
It creates an artificial difference between the VMR and the repo build. But not the end of the world, for sure.
curious why you didn't use PackageDownload?
vcxproj restore (opt in via EnableManagedPackageReferenceSupport
) doesn't support PackageDownload.
This one is finally ready :) |
Updates the .NET SDK to version
10.0.100-preview.3.25122.1
, which also updates the .NET runtime from version10.0.0-preview.2.25109.2
to version10.0.0-preview.2.25119.7
.This pull request was auto-generated by GitHub Actions.