-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .NET SDK to 10.0.100-preview.2.25117.1 #60451
Conversation
Update .NET SDK to version 10.0.100-preview.2.25117.1. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approving SDK update.
cc @ViktorHofer |
Thanks for the ping. At this point it's expected that repos need to react to the NuGet package pruning feature when warning to error promotion is enabled. My PRs (dotnet/sdk#46558 & dotnet/sdk#46829) did parts of this to unblock the VMR builds (source-only & non-source-only). I'm not surprised that there are more parts in individual repositories that need an update as the VMR doesn't exercise a full repository build (i.e. aspnetcore tests don't get built and it looks like the repo tasks project also gets built differently). |
The IDE0059 errors look like false positives to me |
The compiler in that SDK is based on this SHA: dotnet/roslyn@d862b94 |
@BrennanConroy based on the roslyn sha that Viktor mentioned it should already have that change: https://github.com/dotnet/roslyn/blob/d862b947d551d420a2363e4c7d457e768b2fa22c/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/OperationExtensions.cs |
Possible that didn't fix the problem. It was linked to in dotnet/roslyn#77258 by Cyrus as a potential fix. |
I guess we're waiting for the new analyzer to flow into the sdk? cc @dotnet/roslyn-analysis |
fix should be in dotnet/sdk#47003 |
Superseded by #60564. |
Updates the .NET SDK to version
10.0.100-preview.2.25117.1
, which also updates the .NET runtime from version10.0.0-preview.2.25109.2
to version10.0.0-preview.2.25114.1
.This pull request was auto-generated by GitHub Actions.