-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual VMR re-bootstrap to 10.0.100-preview.2.25104.28 #46558
Merged
Merged
+110
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The re-boostrap pipeline failed to open the PR so I'm doing this manually here.
mthalman
approved these changes
Feb 5, 2025
3 tasks
This was referenced Feb 6, 2025
NikolaMilosavljevic
approved these changes
Feb 12, 2025
Fast merge to unblock the broken VMR builds. The previous CI run was successful except for Windows, which gets fixed by the newest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #46530 & dotnet/dotnet#148
The re-boostrap pipeline failed to open the PR so I'm doing this manually here.
Additionally changes were necessary for this PR (see dotnet/scenario-tests#205). In reaction to that, I then also noticed that the scenario-tests
-test
invocation is in a torn state and was using parts of the live built SDK and other parts from the toolset SDK:It also used the bootstrap Arcade SDK instead of the live built Arcade SDK as the other repos do.
The "Test" and "Build" target now share many properties and env vars and targets.