dotnet-watch tests failing #40006
Comments
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
@tmat we still see this fairly frequently. Any luck? Here's a recent one from a codeflow PR: |
|
No luck yet. This might help: https://github.com/dotnet/sdk/blob/d45e40d665e647804de03d2b4eec2aae9c488cb5/test/dotnet-watch.Tests/xunit.runner.json It will print out test info every 20 seconds a test is running. |
|
@tmat another failure this morning shows a bunch of build processes for watch apps still running... https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-sdk-refs-pull-41958-merge-84357342ee154a5088/dotnet-watch.Tests.dll.2/1/console.3dddc463.log?helixlogtype=result |
|
Looks like that's in 8.0 branch. Porting test diagnostics from 9: #41963 |
|
This has been making one of my PRs fail today, so I looked into it a bit. Based on when this issue was created and which tests are failing, I suspect this PR: I asked jasonmalinowski whether the MSBuildWorkspace is supposed to support F# because I'd found a code snippet that suggested that it shouldn't, and he said it doesn't and never did. Did that PR make us use MSBuildWorkspace in a different way than we had before? |
|
The changes to HotReloadDotNetWatcher look most suspicious to me. It looks like a substantial change to how we call MSBuild. |
|
Ping @tmat |
|
@tmat Thank you for making some PRs to try to remedy this -- we are still seeing this in 9.0.2xx, 9.0.1xx, and main, 10 preview 2. Do your changes need to be ported? |
|
They don't flow automatically to main? Re 9.0.2xx, 9.0.1xx - these are product changes. Do they meet the servicing bar? |
|
They should flow to main, but either something went wrong and it didn't for those PRs, or the fix did not work, since it is still showing up in .net 10 preview 2: #46983 I dont think they would meet the bar that, so good point. 9.0.3xx though, they probably do. |
|
Might be something else causing failure in 10 P2. Do you have a link to the failed run? The PR is merged. |
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=629827
Build error leg or test failing: dotnet-watch.Tests.dll.1.WorkItemExecution
Pull request: #39888
Error Message
##[error].packages/microsoft.dotnet.helix.sdk/8.0.0-beta.24177.1/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(89,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item dotnet-watch.Tests.dll.1 in job 82728a56-9430-4356-ab82-1c21670792a7 has failed
{ "ErrorMessage": "", "ErrorPattern": "Work item dotnet-watch\\.Tests\\.dll\\.1 in job [a-z0-9\\-]+ has failed", "BuildRetry": true, "ExcludeConsoleLog": true }Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=629827
Error message validated:
[Work item dotnet-watch\.Tests\.dll\.1 in job [a-z0-9\-]+ has failed]Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/4/2024 9:51:10 AM UTC
Report
Summary
The text was updated successfully, but these errors were encountered: