[release/10.0.1xx] Track mono aot in telemetry too #50864
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @danroth27 |
baronfel
approved these changes
Sep 16, 2025
|
/cc @matouskozak |
matouskozak
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds telemetry tracking for the RunAOTCompilation property to monitor Ahead-Of-Time compilation usage alongside existing AOT-related telemetry. The changes ensure that mono AOT compilation scenarios are now captured in diagnostic data.
- Added
RunAOTCompilationto the target framework telemetry collection - Updated test infrastructure to include the new telemetry parameter in JSON generation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.TargetFrameworkInference.targets | Added RunAOTCompilation property to TFTelemetry collection |
| test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildANetCoreAppForTelemetry.cs | Updated telemetry JSON generation method to include runAotCompilation parameter |
test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildANetCoreAppForTelemetry.cs
Show resolved
Hide resolved
This was referenced Sep 30, 2025
|
happy to take it - seems like it got caught in the general build issues we were having at the time. |
|
/azp run dotnet-sdk-public-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for collecting telemetry on the
RunAOTCompilationproperty in both the build targets and the associated telemetry tests. The changes ensure that the value ofRunAOTCompilationis now tracked and included in telemetry output, which will help with diagnostics and analytics related to Ahead-Of-Time (AOT) compilation.Telemetry enhancements:
TFTelemetryitem forRunAOTCompilationin theMicrosoft.NET.TargetFrameworkInference.targetsfile to capture its value during builds.CreateTargetFrameworkEvalTelemetryJsonmethod inGivenThatWeWantToBuildANetCoreAppForTelemetry.csto include therunAotCompilationparameter and property in the generated telemetry JSON.