-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Port new options auth sample #6363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is giving more false hope than real help. Until you can use it with a real provider like OAuth, OIDC, or JWT, it's not actually useful.
</PropertyGroup> | ||
<ItemGroup> | ||
<PackageReference Include="Microsoft.AspNetCore" Version="$(MicrosoftAspNetCorePackageVersion)" /> | ||
<PackageReference Include="Microsoft.AspNetCore.Authentication.Google" Version="$(MicrosoftAspNetCoreAuthenticationGooglePackageVersion)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natemcmaster what's the new process to update the dependencies.props for AuthSamples? We are using the google reference to pull in the dependency right now, we just need the MicrosoftAspNetCoreAuthenticationPackageVersion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not false hope, but more of a basic building block that is needed to configure options per tenant, I can put a big disclaimer in the readme that additional work will need to be done to actually make the security/auth handlers work. This is basically options + multitenant (ignoring security stack and above) |
That's the piece our customers need. If we're not going to provide that then why bother explaining the incomplete building blocks? |
Because people have asked about these pieces specifically in the past, that will need to do something similar to this to get their multitenancy to work |
Discussed in triage, we feel this sample isn't worth it because it doesn't do enough to help with real scenarios. |
@HaoK was this sample abandoned and never ported (per Eilon's comment above)? I certainly don't see it in the new Aspnet samples repo. |
Port of aspnet/AuthSamples#44