Skip to content

Port new options auth sample #6363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Port new options auth sample #6363

wants to merge 1 commit into from

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jan 3, 2019

Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is giving more false hope than real help. Until you can use it with a real provider like OAuth, OIDC, or JWT, it's not actually useful.

</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore" Version="$(MicrosoftAspNetCorePackageVersion)" />
<PackageReference Include="Microsoft.AspNetCore.Authentication.Google" Version="$(MicrosoftAspNetCoreAuthenticationGooglePackageVersion)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natemcmaster what's the new process to update the dependencies.props for AuthSamples? We are using the google reference to pull in the dependency right now, we just need the MicrosoftAspNetCoreAuthenticationPackageVersion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update manually, or wait for @jkotalik who is starting on #4246 for auth samples soon.

@HaoK
Copy link
Member Author

HaoK commented Jan 3, 2019

Its not false hope, but more of a basic building block that is needed to configure options per tenant, I can put a big disclaimer in the readme that additional work will need to be done to actually make the security/auth handlers work. This is basically options + multitenant (ignoring security stack and above)

@Tratcher
Copy link
Member

Tratcher commented Jan 4, 2019

(ignoring security stack and above)

That's the piece our customers need. If we're not going to provide that then why bother explaining the incomplete building blocks?

@HaoK
Copy link
Member Author

HaoK commented Jan 4, 2019

Because people have asked about these pieces specifically in the past, that will need to do something similar to this to get their multitenancy to work

@jkotalik
Copy link
Contributor

@HaoK once #6772 is done you can continue with this PR (which should be merged shortly).

@Eilon Eilon added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jan 18, 2019
@Eilon
Copy link
Member

Eilon commented Apr 18, 2019

Discussed in triage, we feel this sample isn't worth it because it doesn't do enough to help with real scenarios.

@Eilon Eilon closed this Apr 18, 2019
@HaoK HaoK deleted the haok/1-3opt branch December 5, 2019 16:56
@pseabury
Copy link

pseabury commented Sep 9, 2020

@HaoK was this sample abandoned and never ported (per Eilon's comment above)? I certainly don't see it in the new Aspnet samples repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants