Skip to content

Fix test discovery #8201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2019
Merged

Fix test discovery #8201

merged 3 commits into from
Mar 5, 2019

Conversation

BrennanConroy
Copy link
Member

No description provided.

@BrennanConroy BrennanConroy mentioned this pull request Mar 5, 2019
Merged
@jkotalik
Copy link
Contributor

jkotalik commented Mar 5, 2019

I don't think that fixed it. https://mc.dot.net/#/user/aspnetcore/pr~2Faspnet~2Faspnetcore/ci/20190304.47/workItem/Microsoft.AspNetCore.SignalR.StackExchangeRedis.Tests-netcoreapp3.0/wilogs

Still failed with the same error.

@BrennanConroy
Copy link
Member Author

It was actually a slightly different error

@BrennanConroy
Copy link
Member Author

Ok, now it's fixed

@BrennanConroy
Copy link
Member Author

The 2 test failures in Helix already have PRs to skip them

@BrennanConroy BrennanConroy merged commit c8c12cd into master Mar 5, 2019
@BrennanConroy BrennanConroy deleted the brecon/process branch March 5, 2019 07:11
@analogrelay analogrelay mentioned this pull request Mar 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@mikaelm12 mikaelm12 Awaiting requested review from mikaelm12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrennanConroy @jkotalik @halter73