Skip to content

Fix test discovery #8201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2019
Merged

Fix test discovery #8201

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6fb0de
Fix test discovery
BrennanConroy Mar 5, 2019
5cd18fb
more
BrennanConroy Mar 5, 2019
b43ea79
compile
BrennanConroy Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/SignalR/server/StackExchangeRedis/test/Docker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public int RunCommand(string commandAndArguments, string prefix, out string outp

public int RunCommand(string commandAndArguments, string prefix, ILogger logger, out string output)
{
return RunProcessAndWait(_path, commandAndArguments, prefix, logger, TimeSpan.FromSeconds(5), out output);
return RunProcessAndWait(_path, commandAndArguments, prefix, logger, TimeSpan.FromSeconds(30), out output);
}

private static void RunProcessAndThrowIfFailed(string fileName, string arguments, string prefix, ILogger logger, TimeSpan timeout)
Expand All @@ -155,10 +155,14 @@ private static int RunProcessAndWait(string fileName, string arguments, string p
{
process.Close();
logger.LogError("Closing process '{processName}' because it is running longer than the configured timeout.", fileName);
output = string.Join(Environment.NewLine, lines.ToArray());
return -1;
}
else
{
// Need to WaitForExit without a timeout to guarantee the output stream has written everything
process.WaitForExit();
}

// Need to WaitForExit without a timeout to guarantee the output stream has written everything
process.WaitForExit();

output = string.Join(Environment.NewLine, lines);

Expand Down