Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #7729 to ensure upgradable bundles #8450

Merged
merged 4 commits into from
Mar 20, 2019
Merged

Fix for #7729 to ensure upgradable bundles #8450

merged 4 commits into from
Mar 20, 2019
+34 −5

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Mar 12, 2019

  • Stabilize bundle UpgradeCodes to Major.Minor.Patch (split on x86, x64).
  • Add build version to the bundle version - this ensures higher generated version numbers, e.g. 3.0.0.10200 and 3.0.0.10250

Addresses #7729

@joeloff
Copy link
Member Author

joeloff commented Mar 12, 2019

@johnbeisner @muratg @natemcmaster @Eilon

@Eilon Eilon added the feature-installers Includes: Installers label Mar 12, 2019
@joeloff joeloff requested a review from Tratcher March 19, 2019 17:55
@jkotalik
Copy link
Contributor

Bad merge?

@joeloff
Copy link
Member Author

joeloff commented Mar 19, 2019

Very bad merge/rebase. I'm working on fixing this, ignore for now please

@joeloff
Copy link
Member Author

joeloff commented Mar 20, 2019

@anurse

@analogrelay
Copy link
Contributor

Ahoy hoy

What's up?

@joeloff
Copy link
Member Author

joeloff commented Mar 20, 2019

Need someone from ASP.NET side to approve.

jkotalik
jkotalik approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@jkotalik jkotalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeloff joeloff merged commit 314f67e into master Mar 20, 2019
@Eilon Eilon mentioned this pull request Apr 5, 2019
Closed
@natemcmaster natemcmaster deleted the joeloff/7729 branch May 3, 2019 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotalik jkotalik

@johnbeisner johnbeisner

@BrennanConroy BrennanConroy

@dougbu dougbu

@halter73 halter73

@mikaelm12 mikaelm12

@ryanbrandenburg ryanbrandenburg

@SteveSandersonMS SteveSandersonMS

@Tratcher Tratcher

Assignees
No one assigned
Labels
feature-installers Includes: Installers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joeloff @jkotalik @analogrelay @johnbeisner @Eilon