Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Hosting Bundle should upgrade in place within a major.minor product band #7729

Closed
dagood opened this issue Feb 20, 2019 · 6 comments
Closed

Windows Hosting Bundle should upgrade in place within a major.minor product band #7729

dagood opened this issue Feb 20, 2019 · 6 comments
Assignees
@joeloff
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers
Milestone
3.0.0-preview4

Comments

@dagood
Copy link
Member

dagood commented Feb 20, 2019

When I install a new patch version of the hosting bundle, old patch versions with the same major and minor versions should be uninstalled. For example, installing 3.0.1 should uninstall 3.0.0.

This is part of implementing in-place upgrade across Windows .NET Core installers: https://github.com/dotnet/core-setup/issues/4188.

dotnet/installer#530 implements this for the .NET Core SDK bundle, and the same work is planned for the .NET Core Runtime bundle.

@natemcmaster @joeloff
@natemcmaster natemcmaster added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Feb 20, 2019
@joeloff
Copy link
Member

joeloff commented Feb 20, 2019

I chatted with @Eilon and @muratg, will probably do this after preview 3 since the deadline is today and doesn't provide enough time to fully test the changes

@muratg muratg added this to the 3.0.0-preview4 milestone Feb 21, 2019
@joeloff
Copy link
Member

joeloff commented Feb 27, 2019

PR is almost complete. I'm just waiting on the final preview 3 build to drop

joeloff added a commit that referenced this issue Mar 12, 2019
@joeloff
Fix for #7729 to ensure upgradable bundles
b1c69a2
@joeloff joeloff mentioned this issue Mar 12, 2019
Merged
joeloff added a commit that referenced this issue Mar 19, 2019
@joeloff
Fix for #7729 to ensure upgradable bundles
f87c75a
joeloff added a commit that referenced this issue Mar 20, 2019
@joeloff
Merge pull request #8450 from aspnet/joeloff/7729
314f67e 
Fix for #7729 to ensure upgradable bundles
@Eilon Eilon modified the milestones: 3.0.0-preview4, 3.0.0-preview6 Apr 5, 2019
@Eilon
Copy link
Member

Eilon commented Apr 5, 2019

@joeloff - is the Hosting Bundle work for this already done in #8450 ? Should this bug be closed?

@Eilon Eilon removed this from the 3.0.0-preview6 milestone Apr 5, 2019
@joeloff
Copy link
Member

joeloff commented Apr 5, 2019

I have a few more tests to run, then I'll close it. Probably Monday if that's okay

@Eilon
Copy link
Member

Eilon commented Apr 5, 2019

Sounds good. Monday @ noon we branch, but if it's just tests, just keep checking into master, and you're good to go.

@Eilon Eilon added this to the 3.0.0-preview4 milestone Apr 5, 2019
@joeloff
Copy link
Member

joeloff commented Apr 8, 2019

Testing looks good. I've done a couple of upgrades from the preview1 and 2 hosting bundles to the preview4 build.

@joeloff joeloff closed this as completed Apr 8, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
@JunTaoLuo JunTaoLuo added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers and removed feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform labels Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeloff joeloff

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers
Projects
None yet
Milestone
3.0.0-preview4
Development

No branches or pull requests
6 participants
@Eilon @muratg @JunTaoLuo @natemcmaster @joeloff @dagood