Enabling the upgrade of the SDK bundle in a product-band #530
+36
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbeisner
requested review from
nguerrera,
livarcocc,
KathleenDollard and
a team
|
Will this value be visible anywhere to the user? I had trouble following some of this: Could you give a couple of examples? It sounds like 3.0.1x86, which makes me a bit uncomfortable compared to 3.0.100x86, just because I like to be consistent with our version numbers. |
|
@KathleenDollard |
nguerrera
reviewed
Feb 15, 2019
joeloff
reviewed
Feb 15, 2019
|
What's the experience when old sdk is in use? Prompt to terminate processes? Prompt to reboot? |
added 4 commits
February 19, 2019 20:35
… upgrade-code being that of '3.0.1xx'.
…the correct full 'display' version.
johnbeisner
force-pushed
the
UpgradeCode
branch
from
6a324be to
19c792a
Compare
|
@leecow I am getting ready to merge this PR today: 2/19/2019 |
dagood
approved these changes
Feb 19, 2019
joeloff
approved these changes
Feb 19, 2019
This was referenced Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: https://github.com/dotnet/core-setup/issues/4188
Enabling the 'upgrade' of the SDK bundle in a 'product-band'.
src/redist/targets/GenerateMSIs.targets
src/redist/targets/GetRuntimeInformation.targets
src/redist/targets/Versions.targets
The upgrade code is based on: "an arbitrary string + the SDK product-band [3.0.1] + the bitness"
In this way, the upgrade codes, x64 & x86, will correctly change when the SDK product-band changes.
src/redist/targets/packaging/windows/clisdk/bundle.wxs
We have stated that we want the 3.0.1 preview 1 and preview 2 to be included in the 'upgrade':
https://github.com/dotnet/core-sdk/releases/tag/v3.0.100-preview-009812
https://github.com/dotnet/core-sdk/releases/tag/v3.0.100-preview-010184
Note: the upgrade codes were harvested via dark.exe against:
dotnet-sdk-3.0.100-preview-009812-win-x64.exe
dotnet-sdk-3.0.100-preview-009812-win-x86.exe
dotnet-sdk-3.0.100-preview-010184-win-x64.exe
dotnet-sdk-3.0.100-preview-010184-win-x86.exe
@leecow
@dagood
@joeloff
@JunTaoLuo
@dleeapho
Manual testing:
Install SDK bundles x64 3.0.1 preview 1 and 2
Install private x64 SDK bundle
Correctly removed 3.0.1 preview 1 and 2