This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[WIP] Enabling the upgrade of the .NET Core Runtime bundle in a product-band #5248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbeisner
requested review from
nguerrera,
livarcocc,
leecow,
KathleenDollard,
joeloff and
dagood
dagood
approved these changes
Feb 26, 2019
Co-Authored-By: johnbeisner <johnbeisner@users.noreply.github.com>
johnbeisner
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling the 'upgrade' of the .NET Core Runtime bundle in a 'product-band'.
Addresses: https://github.com/dotnet/core-setup/issues/4188
Related: dotnet/installer#530
BranchInfo.props
src/pkg/packaging/dir.props
The upgrade code is based on: "an arbitrary string + the .Net Core product-band [3.0] + the RID"
In this way, the upgrade codes, x64 & x86, will correctly change when the SDK product-band changes.
src/pkg/packaging/windows/package.targets
Send the stable upgrade code to the bundle generation script.
@dotnet/dotnet-cli