Skip to content

Update cmake for SignalR C++ client on Mac OS X #8669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wegylexy
Copy link
Contributor

Summary of the changes

  • Skip gtest
  • Patch Boost and OpenSSL in /usr/local/opt
brew install cpprestsdk boost openssl
cmake .. -DCMAKE_CXX_FLAGS=-I/usr/local/opt/openssl/include -DCPPREST_INCLUDE_DIR=/usr/local/opt/cpprestsdk/include -DCPPREST_LIB_DIR=/usr/local/opt/cpprestsdk/lib
make

Addresses #8066

@dnfclas
Copy link

dnfclas commented Mar 20, 2019

CLA assistant check
All CLA requirements met.

@Eilon Eilon added the area-signalr Includes: SignalR clients and servers label Mar 20, 2019
@BrennanConroy
Copy link
Member

Thanks for your interest in the C++ client!

Unfortunately we aren't ready to take CMake changes yet.

We need to setup our CI builds to build and test the client on the different OS's first so we don't accidentally break the build files. And we'll want more than just macOS working.

We have already started looking into making CMake work cross-plat, you can see the WIP changes in the branch https://github.com/aspnet/AspNetCore/tree/brecon/cmake

I've filed #8706 so we can track and discuss things there if you'd like.

@wegylexy
Copy link
Contributor Author

It already works on Ubuntu before this change. Mac just needs more help to find Boost and OpenSSL. For Windows, we have Visual Studio. So after this change, all 3 platforms can build.

@analogrelay
Copy link
Contributor

Thanks for the PR, but we have some build process stuff to integrate with (version numbers to align with and MSBuild goop to connect it up to). As @BrennanConroy said, we're working on getting this in soon. I'm going to close this since the changes we've already got will end up conflicting with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants