This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add targeting pack data/PackageOverrides.txt files #7369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSimons
approved these changes
Jul 24, 2019
There was a problem hiding this comment.
Does this fully address https://github.com/dotnet/core-setup/issues/3607 as well then?
|
It's not clear to me if there's potential for this to happen in 3.0+:
This PR didn't add any package overrides, so I didn't see if it makes sense to generate the list. Maybe we can clean up that related issue though. I'll ping it with a question. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
data/PackageOverrides.txtto the NETCoreApp and NETStandard targeting packs. Content is static and not expected to change.For https://github.com/dotnet/core-setup/issues/6507.
I'll port to 3.0 immediately after merging to unblock SDK work depending on this.
/cc @dsplaisted @ericstj