Update PackageOverrides.txt #104638

ViktorHofer · 2024-07-09T20:06:04Z

Update PackageOverrides.txt which ships inside the Microsoft.NETCore.App.Ref targeting pack with the latest state for .NET 9.

This improves build perf as assembly version checks are avoided for the packages listed with a version lower or equal.

Filed #104639 for adding some automation.

I went through the entire list of inbox libraries from

runtime/src/libraries/NetCoreAppLibrary.props

Line 28 in 5795e8c

and checked if there's a package for it and if so, added it to the list or updated its entry. I also updated all the existing entries with the latest package version.

Update PackageOverrides.txt which ships inside the Microsoft.NETCore.App.Ref targeting pack with the latest state for .NET 9. This improves build perf as assembly version checks are avoided for the packages listed with a version lower or equal.

ViktorHofer · 2024-07-09T20:06:28Z

src/installer/pkg/sfx/Microsoft.NETCore.App/PackageOverrides.txt

 System.Security.Cryptography.Primitives|4.3.0
-System.Security.Cryptography.X509Certificates|4.3.0
-System.Security.Cryptography.Xml|4.4.0


From what I can see, this line is wrong as System.Security.Cryptography.Xml was never inbox.

Note that it is "inbox" in Microsoft.AspNetCore.App (which means its not inbox in Microsoft.NETCore.App)

It's in ASP.NET Core but not .NETCore. Surprising that no-one ever hit this, maybe because the package version was old? Or folks listen to us and don't actually use it. I confirmed your analysis in 2.0 - 9.0. Thanks for catching it and removing it.

@eerhardt I see that an entry for it is missing in https://github.com/dotnet/aspnetcore/blob/main/eng/PackageOverrides.txt. There might be others that are missing. Should I file an issue?

It's there: https://github.com/dotnet/aspnetcore/blob/96f53b4cd0d39c378adf18d908d493ac3a7f522e/eng/PackageOverrides.txt#L38

Not sorted 😕

Looks like ASP.NET's should be updated to no longer include System.IO.Pipelines, since that is now in NETCore.App.

@eerhardt will you take care of updating the PackageOverrides list in aspnetcore or do you want me to file an issue?

I've opened dotnet/aspnetcore#56724 to track updating aspnetcore's file.

ViktorHofer · 2024-07-09T20:11:22Z

cc @eerhardt

eerhardt · 2024-07-09T20:20:32Z

src/installer/pkg/sfx/Microsoft.NETCore.App/PackageOverrides.txt

+System.Text.Encodings.Web|9.0.0
+System.Text.Json|9.0.0


These 9.0.0 ones are interesting. Is there a reason they weren't included to begin with?

Good question. System.Text.Json is a new package but System.Text.Encodings.Web existed since 2015 and has been inbox since at least netcoreapp2.0. If I'm not mistaken it was you who created the initial list?

This list hasn't changed since you originally added it. I think we were letting platform manifest do the work then.

With PackageOverrides we can short circuit that work. It can also help if we eventually feed this data into NuGet for supplied by platform (short circuiting even earlier in restore).

If I'm not mistaken it was you who created the initial list?

I believe it was initially added in dotnet/core-setup#7369.

That was just copied from your list: https://github.com/dotnet/core-setup/pull/7369/files#diff-d43a6b44d056f972850070a59b2db1c58d30dd708de5b8a27f492a4b97d71210R4

ericstj

We should consider what's more maintainable for packages that are still built in maintenance-packages or older runtime but not current runtime.

src/installer/pkg/sfx/Microsoft.NETCore.App/PackageOverrides.txt

ericstj · 2024-07-09T20:25:48Z

src/installer/pkg/sfx/Microsoft.NETCore.App/PackageOverrides.txt

+System.Text.Encodings.Web|9.0.0
+System.Text.Json|9.0.0


This list hasn't changed since you originally added it. I think we were letting platform manifest do the work then.

With PackageOverrides we can short circuit that work. It can also help if we eventually feed this data into NuGet for supplied by platform (short circuiting even earlier in restore).

ericstj · 2024-07-09T20:29:09Z

src/installer/pkg/sfx/Microsoft.NETCore.App/PackageOverrides.txt

 System.Security.Cryptography.Primitives|4.3.0
-System.Security.Cryptography.X509Certificates|4.3.0
-System.Security.Cryptography.Xml|4.4.0


It's there: https://github.com/dotnet/aspnetcore/blob/96f53b4cd0d39c378adf18d908d493ac3a7f522e/eng/PackageOverrides.txt#L38

Not sorted 😕

Update packages that aren't produced from runtime/main anymore but from other branches or from the maintenance-packages repository.

ViktorHofer

I updated the package versions for ones that will ship again from maintenance-packages or from a servicing branch. Any other feedback?

ViktorHofer · 2024-07-15T13:53:14Z

@ericstj / @eerhardt any more feedback? If not, would you mind approving the PR?

eerhardt

LGTM. Just some minor questions/comments.

eerhardt · 2024-07-15T14:26:13Z

src/installer/pkg/sfx/Microsoft.NETCore.App/PackageOverrides.txt

 System.Xml.XDocument|4.3.0
 System.Xml.XmlDocument|4.3.0
 System.Xml.XmlSerializer|4.3.0
 System.Xml.XPath|4.3.0
-System.Xml.XPath.XDocument|4.3.0
+System.Xml.XPath.XDocument|5.0.0


We haven't shipped a new version of System.Xml.XPath.XDocument since 2016. Why does it get 5.0.0 and the other System.Xml packages don't?

This package and a few others (i.e. DispatchProxy that you commented on below) will soon get a new version for servicing. The sources got moved to https://github.com/dotnet/maintenance-packages/tree/main/src.

eerhardt · 2024-07-15T14:38:00Z

src/installer/pkg/sfx/Microsoft.NETCore.App/PackageOverrides.txt

-System.Reflection.Emit|4.3.0
-System.Reflection.Emit.ILGeneration|4.3.0
-System.Reflection.Emit.Lightweight|4.3.0
+System.Reflection.DispatchProxy|6.0.0


I think this one can stay at 5.0.0, we never shipped a 5.0.0 (just 5.0.0-preview packages for a while), and it makes it consistent with the other 4.x packages.

ericstj · 2024-07-16T15:32:44Z

LGTM

Update PackageOverrides.txt

de22a33

Update PackageOverrides.txt which ships inside the Microsoft.NETCore.App.Ref targeting pack with the latest state for .NET 9. This improves build perf as assembly version checks are avoided for the packages listed with a version lower or equal.

ViktorHofer requested a review from ericstj July 9, 2024 20:06

ViktorHofer self-assigned this Jul 9, 2024

dotnet-issue-labeler bot added the area-Setup label Jul 9, 2024

ViktorHofer commented Jul 9, 2024

View reviewed changes

ViktorHofer mentioned this pull request Jul 9, 2024

Automate parts of the PackageOverrides.txt #104639

Closed

eerhardt reviewed Jul 9, 2024

View reviewed changes

ericstj reviewed Jul 9, 2024

View reviewed changes

Update packages which will ship again

45900e2

Update packages that aren't produced from runtime/main anymore but from other branches or from the maintenance-packages repository.

ViktorHofer commented Jul 10, 2024

View reviewed changes

eerhardt mentioned this pull request Jul 10, 2024

Update PackageOverrides.txt for latest packages dotnet/aspnetcore#56724

Closed

This was referenced Jul 10, 2024

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

The job running on agent NetCore-Public ran longer than the maximum time #104044

Closed

eerhardt approved these changes Jul 15, 2024

View reviewed changes

ViktorHofer merged commit 9600a8c into main Jul 15, 2024
73 of 78 checks passed

ViktorHofer deleted the ViktorHofer-patch-2 branch July 15, 2024 15:38

build-analysis bot mentioned this pull request Jul 15, 2024

[browser][WBT] SignalRPassMessageWasmBrowser - NU1903 - System.Text.Json 8.0.0 #104737

Closed

github-actions bot locked and limited conversation to collaborators Aug 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update PackageOverrides.txt #104638

Update PackageOverrides.txt #104638

ViktorHofer commented Jul 9, 2024 •

edited

Loading

ViktorHofer Jul 9, 2024 •

edited

Loading

eerhardt Jul 9, 2024 •

edited

Loading

ericstj Jul 9, 2024

ViktorHofer Jul 9, 2024 •

edited

Loading

ericstj Jul 9, 2024

eerhardt Jul 9, 2024

ViktorHofer Jul 10, 2024

eerhardt Jul 10, 2024

ViktorHofer commented Jul 9, 2024

eerhardt Jul 9, 2024

ViktorHofer Jul 9, 2024 •

edited

Loading

ericstj Jul 9, 2024

eerhardt Jul 9, 2024

ViktorHofer Jul 9, 2024

ericstj left a comment

ericstj Jul 9, 2024

ericstj Jul 9, 2024

ViktorHofer left a comment

ViktorHofer commented Jul 15, 2024

eerhardt left a comment

eerhardt Jul 15, 2024

ViktorHofer Jul 15, 2024

eerhardt Jul 15, 2024

ericstj commented Jul 16, 2024

		System.Text.Encodings.Web\|9.0.0
		System.Text.Json\|9.0.0

		System.Text.Encodings.Web\|9.0.0
		System.Text.Json\|9.0.0

Update PackageOverrides.txt #104638

Update PackageOverrides.txt #104638

Conversation

ViktorHofer commented Jul 9, 2024 • edited Loading

ViktorHofer Jul 9, 2024 • edited Loading

Choose a reason for hiding this comment

eerhardt Jul 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ViktorHofer Jul 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ViktorHofer commented Jul 9, 2024

Choose a reason for hiding this comment

ViktorHofer Jul 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericstj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ViktorHofer left a comment

Choose a reason for hiding this comment

ViktorHofer commented Jul 15, 2024

eerhardt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericstj commented Jul 16, 2024

ViktorHofer commented Jul 9, 2024 •

edited

Loading

ViktorHofer Jul 9, 2024 •

edited

Loading

eerhardt Jul 9, 2024 •

edited

Loading

ViktorHofer Jul 9, 2024 •

edited

Loading

ViktorHofer Jul 9, 2024 •

edited

Loading