Update PackageOverrides.txt #104638
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,91 +1,97 @@ | ||
| Microsoft.CSharp|4.7.0 | ||
| Microsoft.VisualBasic|10.4.0 | ||
| Microsoft.Win32.Primitives|4.3.0 | ||
| Microsoft.Win32.Registry|5.0.0 | ||
| runtime.debian.8-x64.runtime.native.System|4.3.1 | ||
| runtime.debian.8-x64.runtime.native.System.IO.Compression|4.3.2 | ||
| runtime.debian.8-x64.runtime.native.System.Net.Http|4.3.1 | ||
| runtime.debian.8-x64.runtime.native.System.Net.Security|4.3.1 | ||
| runtime.debian.8-x64.runtime.native.System.Security.Cryptography|4.3.4 | ||
| runtime.debian.8-x64.runtime.native.System.Security.Cryptography.OpenSsl|4.3.3 | ||
| runtime.fedora.23-x64.runtime.native.System|4.3.1 | ||
| runtime.fedora.23-x64.runtime.native.System.IO.Compression|4.3.2 | ||
| runtime.fedora.23-x64.runtime.native.System.Net.Http|4.3.1 | ||
| runtime.fedora.23-x64.runtime.native.System.Net.Security|4.3.1 | ||
| runtime.fedora.23-x64.runtime.native.System.Security.Cryptography|4.3.4 | ||
| runtime.fedora.23-x64.runtime.native.System.Security.Cryptography.OpenSsl|4.3.3 | ||
| runtime.fedora.24-x64.runtime.native.System|4.3.1 | ||
| runtime.fedora.24-x64.runtime.native.System.IO.Compression|4.3.2 | ||
| runtime.fedora.24-x64.runtime.native.System.Net.Http|4.3.1 | ||
| runtime.fedora.24-x64.runtime.native.System.Net.Security|4.3.1 | ||
| runtime.fedora.24-x64.runtime.native.System.Security.Cryptography|4.3.4 | ||
| runtime.fedora.24-x64.runtime.native.System.Security.Cryptography.OpenSsl|4.3.3 | ||
| runtime.opensuse.13.2-x64.runtime.native.System|4.3.1 | ||
| runtime.opensuse.13.2-x64.runtime.native.System.IO.Compression|4.3.2 | ||
| runtime.opensuse.13.2-x64.runtime.native.System.Net.Http|4.3.1 | ||
| runtime.opensuse.13.2-x64.runtime.native.System.Net.Security|4.3.1 | ||
| runtime.opensuse.13.2-x64.runtime.native.System.Security.Cryptography|4.3.4 | ||
| runtime.opensuse.13.2-x64.runtime.native.System.Security.Cryptography.OpenSsl|4.3.3 | ||
| runtime.opensuse.42.1-x64.runtime.native.System|4.3.1 | ||
| runtime.opensuse.42.1-x64.runtime.native.System.IO.Compression|4.3.2 | ||
| runtime.opensuse.42.1-x64.runtime.native.System.Net.Http|4.3.1 | ||
| runtime.opensuse.42.1-x64.runtime.native.System.Net.Security|4.3.1 | ||
| runtime.opensuse.42.1-x64.runtime.native.System.Security.Cryptography|4.3.4 | ||
| runtime.opensuse.42.1-x64.runtime.native.System.Security.Cryptography.OpenSsl|4.3.3 | ||
| runtime.osx.10.10-x64.runtime.native.System|4.3.1 | ||
| runtime.osx.10.10-x64.runtime.native.System.IO.Compression|4.3.2 | ||
| runtime.osx.10.10-x64.runtime.native.System.Net.Http|4.3.1 | ||
| runtime.osx.10.10-x64.runtime.native.System.Net.Security|4.3.1 | ||
| runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography|4.3.4 | ||
| runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.Apple|4.3.1 | ||
| runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.OpenSsl|4.3.3 | ||
| runtime.rhel.7-x64.runtime.native.System|4.3.1 | ||
| runtime.rhel.7-x64.runtime.native.System.IO.Compression|4.3.2 | ||
| runtime.rhel.7-x64.runtime.native.System.Net.Http|4.3.1 | ||
| runtime.rhel.7-x64.runtime.native.System.Net.Security|4.3.1 | ||
| runtime.rhel.7-x64.runtime.native.System.Security.Cryptography|4.3.4 | ||
| runtime.rhel.7-x64.runtime.native.System.Security.Cryptography.OpenSsl|4.3.3 | ||
| runtime.ubuntu.14.04-x64.runtime.native.System|4.3.1 | ||
| runtime.ubuntu.14.04-x64.runtime.native.System.IO.Compression|4.3.2 | ||
| runtime.ubuntu.14.04-x64.runtime.native.System.Net.Http|4.3.1 | ||
| runtime.ubuntu.14.04-x64.runtime.native.System.Net.Security|4.3.1 | ||
| runtime.ubuntu.14.04-x64.runtime.native.System.Security.Cryptography|4.3.4 | ||
| runtime.ubuntu.14.04-x64.runtime.native.System.Security.Cryptography.OpenSsl|4.3.3 | ||
| runtime.ubuntu.16.04-x64.runtime.native.System|4.3.1 | ||
| runtime.ubuntu.16.04-x64.runtime.native.System.IO.Compression|4.3.2 | ||
| runtime.ubuntu.16.04-x64.runtime.native.System.Net.Http|4.3.1 | ||
| runtime.ubuntu.16.04-x64.runtime.native.System.Net.Security|4.3.1 | ||
| runtime.ubuntu.16.04-x64.runtime.native.System.Security.Cryptography|4.3.4 | ||
| runtime.ubuntu.16.04-x64.runtime.native.System.Security.Cryptography.OpenSsl|4.3.3 | ||
| runtime.ubuntu.16.10-x64.runtime.native.System|4.3.1 | ||
| runtime.ubuntu.16.10-x64.runtime.native.System.IO.Compression|4.3.2 | ||
| runtime.ubuntu.16.10-x64.runtime.native.System.Net.Http|4.3.1 | ||
| runtime.ubuntu.16.10-x64.runtime.native.System.Net.Security|4.3.1 | ||
| runtime.ubuntu.16.10-x64.runtime.native.System.Security.Cryptography|4.3.4 | ||
| runtime.ubuntu.16.10-x64.runtime.native.System.Security.Cryptography.OpenSsl|4.3.3 | ||
| System.AppContext|4.3.0 | ||
| System.Buffers|5.0.0 | ||
| System.Collections|4.3.0 | ||
| System.Collections.Concurrent|4.3.0 | ||
| System.Collections.Immutable|9.0.0 | ||
| System.Collections.NonGeneric|4.3.0 | ||
| System.Collections.Specialized|4.3.0 | ||
| System.ComponentModel|4.3.0 | ||
| System.ComponentModel.Annotations|4.3.0 | ||
| System.ComponentModel.EventBasedAsync|4.3.0 | ||
| System.ComponentModel.Primitives|4.3.0 | ||
| System.ComponentModel.TypeConverter|4.3.0 | ||
| System.Console|4.3.1 | ||
| System.Data.Common|4.3.0 | ||
| System.Data.DataSetExtensions|4.4.0 | ||
| System.Diagnostics.Contracts|4.3.0 | ||
| System.Diagnostics.Debug|4.3.0 | ||
| System.Diagnostics.DiagnosticSource|9.0.0 | ||
| System.Diagnostics.FileVersionInfo|4.3.0 | ||
| System.Diagnostics.Process|4.3.0 | ||
| System.Diagnostics.StackTrace|4.3.0 | ||
| System.Diagnostics.TextWriterTraceListener|4.3.0 | ||
| System.Diagnostics.Tools|4.3.0 | ||
| System.Diagnostics.TraceSource|4.3.0 | ||
| System.Diagnostics.Tracing|4.3.0 | ||
| System.Drawing.Primitives|4.3.0 | ||
| System.Dynamic.Runtime|4.3.0 | ||
| System.Formats.Asn1|9.0.0 | ||
| System.Formats.Tar|9.0.0 | ||
| System.Globalization|4.3.0 | ||
| System.Globalization.Calendars|4.3.0 | ||
| System.Globalization.Extensions|4.3.0 | ||
|
|
@@ -94,36 +100,52 @@ System.IO.Compression|4.3.0 | |
| System.IO.Compression.ZipFile|4.3.0 | ||
| System.IO.FileSystem|4.3.0 | ||
| System.IO.FileSystem.AccessControl|4.4.0 | ||
| System.IO.FileSystem.DriveInfo|4.3.1 | ||
| System.IO.FileSystem.Primitives|4.3.0 | ||
| System.IO.FileSystem.Watcher|4.3.0 | ||
| System.IO.IsolatedStorage|4.3.0 | ||
| System.IO.MemoryMappedFiles|4.3.0 | ||
| System.IO.Pipes|4.3.0 | ||
| System.IO.Pipes.AccessControl|5.0.0 | ||
| System.IO.Pipelines|9.0.0 | ||
| System.IO.UnmanagedMemoryStream|4.3.0 | ||
| System.Linq|4.3.0 | ||
| System.Linq.Expressions|4.3.0 | ||
| System.Linq.Parallel|4.3.0 | ||
| System.Linq.Queryable|4.3.0 | ||
| System.Memory|5.0.0 | ||
| System.Net.Http|4.3.4 | ||
| System.Net.Http.Json|9.0.0 | ||
| System.Net.NameResolution|4.3.0 | ||
| System.Net.NetworkInformation|4.3.0 | ||
| System.Net.Ping|4.3.0 | ||
| System.Net.Primitives|4.3.1 | ||
| System.Net.Requests|4.3.0 | ||
| System.Net.Security|4.3.2 | ||
| System.Net.Sockets|4.3.0 | ||
| System.Net.WebHeaderCollection|4.3.0 | ||
| System.Net.WebSockets|4.3.0 | ||
| System.Net.WebSockets.Client|4.3.2 | ||
| System.Numerics.Vectors|5.0.0 | ||
| System.ObjectModel|4.3.0 | ||
| System.Private.DataContractSerialization|4.3.0 | ||
| System.Private.Uri|4.3.2 | ||
| System.Reflection|4.3.0 | ||
| System.Reflection.DispatchProxy|6.0.0 | ||
| System.Reflection.Emit|4.7.0 | ||
| System.Reflection.Emit.ILGeneration|4.7.0 | ||
| System.Reflection.Emit.Lightweight|4.7.0 | ||
| System.Reflection.Extensions|4.3.0 | ||
| System.Reflection.Metadata|9.0.0 | ||
| System.Reflection.Primitives|4.3.0 | ||
| System.Reflection.TypeExtensions|4.3.0 | ||
| System.Resources.Reader|4.3.0 | ||
| System.Resources.ResourceManager|4.3.0 | ||
| System.Resources.Writer|4.3.0 | ||
| System.Runtime|4.3.1 | ||
| System.Runtime.CompilerServices.Unsafe|7.0.0 | ||
| System.Runtime.CompilerServices.VisualC|4.3.0 | ||
| System.Runtime.Extensions|4.3.1 | ||
| System.Runtime.Handles|4.3.0 | ||
| System.Runtime.InteropServices|4.3.0 | ||
| System.Runtime.InteropServices.RuntimeInformation|4.3.0 | ||
|
|
@@ -132,33 +154,39 @@ System.Runtime.Numerics|4.3.0 | |
| System.Runtime.Serialization.Formatters|4.3.0 | ||
| System.Runtime.Serialization.Json|4.3.0 | ||
| System.Runtime.Serialization.Primitives|4.3.0 | ||
| System.Runtime.Serialization.Xml|4.3.0 | ||
| System.Security.AccessControl|6.0.1 | ||
| System.Security.Claims|4.3.0 | ||
| System.Security.Cryptography.Algorithms|4.3.1 | ||
| System.Security.Cryptography.Cng|5.0.0 | ||
| System.Security.Cryptography.Csp|4.3.0 | ||
| System.Security.Cryptography.Encoding|4.3.0 | ||
| System.Security.Cryptography.OpenSsl|5.0.0 | ||
| System.Security.Cryptography.Primitives|4.3.0 | ||
| System.Security.Cryptography.X509Certificates|4.3.2 | ||
|
There was a problem hiding this comment. From what I can see, this line is wrong as System.Security.Cryptography.Xml was never inbox. There was a problem hiding this comment. Note that it is "inbox" in There was a problem hiding this comment. It's in ASP.NET Core but not .NETCore. Surprising that no-one ever hit this, maybe because the package version was old? Or folks listen to us and don't actually use it. I confirmed your analysis in 2.0 - 9.0. Thanks for catching it and removing it. There was a problem hiding this comment. @eerhardt I see that an entry for it is missing in https://github.com/dotnet/aspnetcore/blob/main/eng/PackageOverrides.txt. There might be others that are missing. Should I file an issue? There was a problem hiding this comment. There was a problem hiding this comment. Looks like ASP.NET's should be updated to no longer include System.IO.Pipelines, since that is now in NETCore.App. There was a problem hiding this comment. @eerhardt will you take care of updating the PackageOverrides list in aspnetcore or do you want me to file an issue? There was a problem hiding this comment. I've opened dotnet/aspnetcore#56724 to track updating aspnetcore's file. |
||
| System.Security.Principal|4.3.0 | ||
| System.Security.Principal.Windows|5.0.0 | ||
| System.Security.SecureString|4.3.0 | ||
| System.Text.Encoding|4.3.0 | ||
| System.Text.Encoding.CodePages|9.0.0 | ||
| System.Text.Encoding.Extensions|4.3.0 | ||
| System.Text.Encodings.Web|9.0.0 | ||
| System.Text.Json|9.0.0 | ||
| System.Text.RegularExpressions|4.3.1 | ||
|
Comment on lines
+173
to
+174
There was a problem hiding this comment. These There was a problem hiding this comment. Good question. System.Text.Json is a new package but System.Text.Encodings.Web existed since 2015 and has been inbox since at least netcoreapp2.0. If I'm not mistaken it was you who created the initial list? There was a problem hiding this comment. This list hasn't changed since you originally added it. I think we were letting platform manifest do the work then. With PackageOverrides we can short circuit that work. It can also help if we eventually feed this data into NuGet for supplied by platform (short circuiting even earlier in restore). There was a problem hiding this comment.
I believe it was initially added in dotnet/core-setup#7369. There was a problem hiding this comment. That was just copied from your list: https://github.com/dotnet/core-setup/pull/7369/files#diff-d43a6b44d056f972850070a59b2db1c58d30dd708de5b8a27f492a4b97d71210R4 |
||
| System.Threading|4.3.0 | ||
| System.Threading.Channels|9.0.0 | ||
| System.Threading.Overlapped|4.3.0 | ||
| System.Threading.Tasks|4.3.0 | ||
| System.Threading.Tasks.Dataflow|9.0.0 | ||
| System.Threading.Tasks.Extensions|5.0.0 | ||
| System.Threading.Tasks.Parallel|4.3.0 | ||
| System.Threading.Thread|4.3.0 | ||
| System.Threading.ThreadPool|4.3.0 | ||
| System.Threading.Timer|4.3.0 | ||
| System.ValueTuple|4.5.0 | ||
| System.Xml.ReaderWriter|4.3.1 | ||
| System.Xml.XDocument|4.3.0 | ||
| System.Xml.XmlDocument|4.3.0 | ||
| System.Xml.XmlSerializer|4.3.0 | ||
| System.Xml.XPath|4.3.0 | ||
| System.Xml.XPath.XDocument|5.0.0 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one can stay at
5.0.0, we never shipped a5.0.0(just 5.0.0-preview packages for a while), and it makes it consistent with the other 4.x packages.