Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Add support for ProgID registration #7551

Merged
merged 5 commits into from
Aug 5, 2019

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Aug 3, 2019

This only represents the registration part of the work. There is still work to be done in the SDK to generate a .clsidmap file containing a ProgID.

cc @jkoritzinsky

See: https://github.com/dotnet/coreclr/issues/25966

@AaronRobinsonMSFT
Copy link
Member Author

I have validated this with a custom generated clsidmap instance and it behaves as expected.

@AaronRobinsonMSFT
Copy link
Member Author

This will need to be ported to release/3.0 as well.

cc @MeiChin-Tsai @jeffschwMSFT

@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review August 3, 2019 17:34
Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test that uses this (at least in master)?

src/corehost/cli/comhost/comhost.cpp Outdated Show resolved Hide resolved
@AaronRobinsonMSFT
Copy link
Member Author

Should we add a test that uses this (at least in master)?

I will do that in a future PR. Right now this work is purely a no-op since it is entirely related to the COM system consuming the mapping. I have updated https://github.com/dotnet/core-setup/issues/5113.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 490c403 into dotnet:master Aug 5, 2019
@AaronRobinsonMSFT AaronRobinsonMSFT modified the milestones: 3.0, 5.0 Aug 5, 2019
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the progid_support branch August 9, 2019 18:51
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Add support for ProgID registration

* Update COM activation documentation


Commit migrated from dotnet/core-setup@490c403
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants