This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 217
Add support for ProgID registration (3.0) #7573
Merged
AaronRobinsonMSFT
merged 5 commits into
dotnet:release/3.0
from
AaronRobinsonMSFT:progid_support
Aug 9, 2019
Merged
Add support for ProgID registration (3.0) #7573
AaronRobinsonMSFT
merged 5 commits into
dotnet:release/3.0
from
AaronRobinsonMSFT:progid_support
Aug 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Aug 5, 2019
elinor-fung
approved these changes
Aug 6, 2019
vitek-karas
approved these changes
Aug 6, 2019
Branch is open, feel free to merge once this is approved by tactics (CC @danmosemsft in case I forget to bring up core-setup tomorrow) |
This has been approved from the CoreCLR perspective. |
Didn't get tactics OK yet - @vitek-karas is following up |
@danmosemsft is the tactics approval based in email, or in person? |
@jeffschwMSFT @vitek-karas was going to start a thread with you / aaron to get an approval by email. (We didn't do it in the meeting as none of us had enough context to discuss it) edit: was not Vitek, it was Vivek. Autocomplete. Anyway all sorted out offline. |
vatsan-madhavan
pushed a commit
that referenced
this pull request
Aug 9, 2019
* Add support for ProgID registration * Update COM activation documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for registering a ProgID when a COM class is registered. This only represents the registration part of the work. There is still work to be done in the SDK to generate a .clsidmap file containing a ProgID - dotnet/sdk#3506.
See PR #7551 for post-3.0 release.
Customer Impact
Without this support consumption of COM classes in languages that don't have
GUID
support is impossible.Fixes: dotnet/coreclr#25966
Related: https://github.com/dotnet/coreclr/issues/25946
Regression?
COM support is new in 3.0 so this is not a regression from a previous .NET Core release, but is a regression in COM support from .NET Framework using the
RegAsm
tool.Risk
Minimal. The registration of ProgIDs is ignored if not requested (backwards compat with previous Preview releases) and registration is following specific COM semantics for mapping a ProgID and
CLSID
which means there is no impact on any specific .NET Core path.