Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Add support for ProgID registration (3.0) #7573

Merged

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Aug 5, 2019

Description

Add support for registering a ProgID when a COM class is registered. This only represents the registration part of the work. There is still work to be done in the SDK to generate a .clsidmap file containing a ProgID - dotnet/sdk#3506.

See PR #7551 for post-3.0 release.

Customer Impact

Without this support consumption of COM classes in languages that don't have GUID support is impossible.

Fixes: dotnet/coreclr#25966
Related: https://github.com/dotnet/coreclr/issues/25946

Regression?

COM support is new in 3.0 so this is not a regression from a previous .NET Core release, but is a regression in COM support from .NET Framework using the RegAsm tool.

Risk

Minimal. The registration of ProgIDs is ignored if not requested (backwards compat with previous Preview releases) and registration is following specific COM semantics for mapping a ProgID and CLSID which means there is no impact on any specific .NET Core path.

@AaronRobinsonMSFT
Copy link
Member Author

cc @MeiChin-Tsai @jeffschwMSFT

@wtgodbe
Copy link
Member

wtgodbe commented Aug 7, 2019

Branch is open, feel free to merge once this is approved by tactics (CC @danmosemsft in case I forget to bring up core-setup tomorrow)

@AaronRobinsonMSFT
Copy link
Member Author

This has been approved from the CoreCLR perspective.

@danmoseley
Copy link
Member

Didn't get tactics OK yet - @vitek-karas is following up

@jeffschwMSFT
Copy link
Member

@danmosemsft is the tactics approval based in email, or in person?

@danmoseley
Copy link
Member

danmoseley commented Aug 8, 2019

@jeffschwMSFT @vitek-karas was going to start a thread with you / aaron to get an approval by email. (We didn't do it in the meeting as none of us had enough context to discuss it)

edit: was not Vitek, it was Vivek. Autocomplete. Anyway all sorted out offline.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 05c3d79 into dotnet:release/3.0 Aug 9, 2019
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the progid_support branch August 9, 2019 18:51
vatsan-madhavan pushed a commit that referenced this pull request Aug 9, 2019
* Add support for ProgID registration

* Update COM activation documentation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants