Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Sep 13, 2017

No description provided.

@jkotas jkotas added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 13, 2017
@jkotas jkotas removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 13, 2017
@tarekgh
Copy link
Member

tarekgh commented Sep 13, 2017

@jkotas thanks for fixing this. Why are you marking this as no-merge? do you expect more breaks?

@jkotas
Copy link
Member Author

jkotas commented Sep 13, 2017

There are more breaks, but they are not related to this. I have removed the no merge label already.

@tarekgh
Copy link
Member

tarekgh commented Sep 13, 2017

@jkotas

could you confirm the failures in Windows_NT arm Cross Checked Build and Test are unrelated?

10:33:34  "C:\Users\DDJOIN\arm64_ci\tests\tests\Tests\Core_Root\corerun.exe" mainv1.exe 
10:33:34 Expected: 100
10:33:34 Actual: 3

should we merge this change?

@jashook
Copy link

jashook commented Sep 13, 2017

These failures were introduced by #13733. @jkotas thank you for fixing this.

@jashook
Copy link

jashook commented Sep 13, 2017

/cc @dotnet/arm32-contrib

@jkotas jkotas merged commit c41e519 into dotnet:master Sep 13, 2017
@hqueue
Copy link
Member

hqueue commented Sep 14, 2017

It is surprising this bug was still alive.

Thanks for the fix. :)

@jkotas jkotas deleted the arm-break branch September 14, 2017 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants