This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix potentially unused variable in lb arm #13943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansull
approved these changes
Sep 13, 2017
janvorli
reviewed
Sep 13, 2017
| // Ensure that we don't trash any of these registers if we have to load | ||
| // the helper call target into a register to invoke it. | ||
| regMaskTP regsUsed; | ||
| regMaskTP regsUsed = 0; |
Member
There was a problem hiding this comment.
@jashook was the windows ARM32 compiler complaining about this? It is strange since there already was another place with exactly the same usage pattern before. Also, the regsUsed is always filled in by the regSet.rsLockReg and it is passed to the regSet.rsUnlockReg only if it was set this way. But obviously, the compiler might not see it.
Author
There was a problem hiding this comment.
This was caught by the desktop build. The arm failure is unrelated and being fixed by #13932
janvorli
approved these changes
Sep 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.