Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix potentially unused variable in lb arm #13943

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Fix potentially unused variable in lb arm #13943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/jit/codegenlegacy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18662,7 +18662,7 @@ regMaskTP CodeGen::genCodeForCall(GenTreeCall* call, bool valUsed)
#ifdef _TARGET_ARM_
// Ensure that we don't trash any of these registers if we have to load
// the helper call target into a register to invoke it.
regMaskTP regsUsed;
regMaskTP regsUsed = 0;
Copy link
Member

@janvorli janvorli Sep 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jashook was the windows ARM32 compiler complaining about this? It is strange since there already was another place with exactly the same usage pattern before. Also, the regsUsed is always filled in by the regSet.rsLockReg and it is passed to the regSet.rsUnlockReg only if it was set this way. But obviously, the compiler might not see it.

Copy link
Author

@jashook jashook Sep 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was caught by the desktop build. The arm failure is unrelated and being fixed by #13932

Copy link

@briansull briansull Sep 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Mirror is down right now.


if ((call->gtCallMoreFlags & GTF_CALL_M_SECURE_DELEGATE_INV))
{
Expand Down