This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Remove replaced Span/ReadOnlySpan methods. #16086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please also delete |
|
The few places that started using it again should just use |
Sure thing, done. |
jkotas
approved these changes
Jan 30, 2018
|
It would appear that some of the tests are using an older version of system.private.corelib. I'm getting errors that functions I added last week aren't available: |
|
Yes, you need to get #16091 through first. |
|
Ah, that explains it. Thanks. I'll push the test change to that PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #15941
This PR removes the old functions that are no longer being exposed in corefx as of the merging of dotnet/corefx#26467.
cc: @ahsonkhan @stephentoub