Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively (master) #16091

Merged
merged 4 commits into from
Jan 31, 2018
Merged

Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively (master) #16091

merged 4 commits into from
Jan 31, 2018

Conversation

dotnet-maestro-bot
Copy link

@dotnet-maestro-bot dotnet-maestro-bot commented Jan 30, 2018 •
edited
Loading

/cc @dotnet/coreclr-auto-update-notify

@dotnet-maestro-bot dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from ae60646 to e80d3fd Compare January 30, 2018 02:47
@dotnet-maestro-bot
Copy link
Author

Discarded e80d3fd: Update BuildTools, CoreClr to prerelease-02430-02, preview2-26130-01, respectively

CI Status: 2:x: 9:hourglass: 4:heavy_check_mark: (click to expand)
  • ❌ CentOS7.1 x64 Debug Innerloop Build Build finished. Details
  • ❌ Ubuntu arm64 Cross Debug Innerloop Build Build finished. Details
  • ⌛ Alpine.3.6 x64 Debug Build Started Details
  • ⌛ CentOS7.1 x64 Checked Innerloop Build and Test Started. Details
  • ⌛ OSX10.12 x64 Checked Innerloop Build and Test.* Started. Details
  • ⌛ Tizen armel Cross Checked Innerloop Build and Test Triggered. (13/28 on ubuntu1404-20170120)
  • ⌛ Ubuntu x64 Checked Innerloop Build and Test.* Started. Details
  • ⌛ Ubuntu x64 Formatting Triggered. (2/14 on ubuntu1404-20170925)
  • ⌛ Windows_NT x64 Checked Innerloop Build and Test Started. Details
  • ⌛ Windows_NT x86 Checked Innerloop Build and Test Started. Details
  • ⌛ Windows_NT x86 Release Innerloop Build and Test Started. Details
  • ✔️ CROSS Check Build finished. Details
  • ✔️ license/cla All CLA requirements met. Details
  • ✔️ Windows_NT x64 Formatting Build finished. Details
  • ✔️ WIP ready for review Details

@dotnet-maestro-bot dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from e80d3fd to d03b1f1 Compare January 30, 2018 02:59
@dotnet-maestro-bot
Copy link
Author

Discarded d03b1f1: Update BuildTools, CoreClr to prerelease-02430-02, preview2-26130-01, respectively

CI Status: 4:x: 7:hourglass: 4:heavy_check_mark: (click to expand)
  • ❌ Alpine.3.6 x64 Debug Build Build finished. Details
  • ❌ CentOS7.1 x64 Debug Innerloop Build Build finished. Details
  • ❌ Ubuntu arm64 Cross Debug Innerloop Build Build finished. Details
  • ❌ Ubuntu x64 Formatting Build finished. Details
  • ⌛ CentOS7.1 x64 Checked Innerloop Build and Test Started. Details
  • ⌛ OSX10.12 x64 Checked Innerloop Build and Test.* Started. Details
  • ⌛ Tizen armel Cross Checked Innerloop Build and Test Triggered. (17/28 on ubuntu1404-20170120)
  • ⌛ Ubuntu x64 Checked Innerloop Build and Test.* Started. Details
  • ⌛ Windows_NT x64 Checked Innerloop Build and Test Started. Details
  • ⌛ Windows_NT x86 Checked Innerloop Build and Test Started. Details
  • ⌛ Windows_NT x86 Release Innerloop Build and Test Started. Details
  • ✔️ CROSS Check Build finished. Details
  • ✔️ license/cla All CLA requirements met. Details
  • ✔️ Windows_NT x64 Formatting Build finished. Details
  • ✔️ WIP ready for review Details

@dotnet-maestro-bot dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from d03b1f1 to d0cd001 Compare January 30, 2018 03:43
@dotnet-maestro-bot
Copy link
Author

Discarded d0cd001: Update BuildTools, CoreClr to prerelease-02430-02, preview2-26130-01, respectively

CI Status: 6:x: 1:hourglass: 7:heavy_check_mark: (click to expand)
  • ❌ CentOS7.1 x64 Checked Innerloop Build and Test Build finished. Details
  • ❌ CentOS7.1 x64 Debug Innerloop Build Build finished. Details
  • ❌ OSX10.12 x64 Checked Innerloop Build and Test.* Build finished. Details
  • ❌ Ubuntu arm64 Cross Debug Innerloop Build Build finished. Details
  • ❌ Ubuntu x64 Checked Innerloop Build and Test.* Build finished. Details
  • ❌ Ubuntu x64 Formatting Build finished. Details
  • ⌛ Tizen armel Cross Checked Innerloop Build and Test Triggered. (16/21 on ubuntu1404-20170120)
  • ✔️ CROSS Check Build finished. Details
  • ✔️ license/cla All CLA requirements met. Details
  • ✔️ Windows_NT x64 Checked Innerloop Build and Test Build finished. Details
  • ✔️ Windows_NT x64 Formatting Build finished. Details
  • ✔️ Windows_NT x86 Checked Innerloop Build and Test Build finished. Details
  • ✔️ Windows_NT x86 Release Innerloop Build and Test Build finished. Details
  • ✔️ WIP ready for review Details

@dotnet-maestro-bot dotnet-maestro-bot changed the title Update BuildTools, CoreClr to prerelease-02430-02, preview2-26130-01, respectively (master) Update BuildTools, CoreClr, CoreFx to prerelease-02430-02, preview2-26130-01, preview2-26130-01, respectively (master) Jan 30, 2018
@dotnet-maestro-bot dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from d0cd001 to 0c46d0d Compare January 30, 2018 04:34
@dotnet-maestro-bot
Copy link
Author

Discarded 0c46d0d: Update BuildTools, CoreClr, CoreFx to prerelease-02430-02, preview2-26130-01, preview2-26130-01, respectively

CI Status: 11:x: 4:heavy_check_mark: (click to expand)
  • ❌ Alpine.3.6 x64 Debug Build Build finished. Details
  • ❌ CentOS7.1 x64 Checked Innerloop Build and Test Build finished. Details
  • ❌ CentOS7.1 x64 Debug Innerloop Build Build finished. Details
  • ❌ OSX10.12 x64 Checked Innerloop Build and Test.* Build finished. Details
  • ❌ Tizen armel Cross Checked Innerloop Build and Test Build finished. Details
  • ❌ Ubuntu arm64 Cross Debug Innerloop Build Build finished. Details
  • ❌ Ubuntu x64 Checked Innerloop Build and Test.* Build finished. Details
  • ❌ Ubuntu x64 Formatting Build finished. Details
  • ❌ Windows_NT x64 Checked Innerloop Build and Test Build finished. Details
  • ❌ Windows_NT x86 Checked Innerloop Build and Test Build finished. Details
  • ❌ Windows_NT x86 Release Innerloop Build and Test Build finished. Details
  • ✔️ CROSS Check Build finished. Details
  • ✔️ license/cla All CLA requirements met. Details
  • ✔️ Windows_NT x64 Formatting Build finished. Details
  • ✔️ WIP ready for review Details

@dotnet-maestro-bot dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 0c46d0d to 55f388b Compare January 30, 2018 09:04
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update BuildTools, CoreClr, CoreFx to prerelease-02430-02, preview2-26130-01, preview2-26130-01, respectively (master) Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-02, preview2-26130-01, preview2-26130-01, master-20180130-0046, respectively (master) Jan 30, 2018
@dotnet-maestro-bot
Copy link
Author

Discarded 55f388b: Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-02, preview2-26130-01, preview2-26130-01, master-20180130-0046, respectively

CI Status: 2:x: 2:heavy_check_mark: (click to expand)
  • ❌ Alpine.3.6 x64 Debug Build Build finished. Details
  • ❌ Windows_NT x86 Checked Innerloop Build and Test Build finished. Details
  • ✔️ license/cla All CLA requirements met. Details
  • ✔️ WIP ready for review Details

@dotnet-maestro-bot dotnet-maestro-bot changed the title Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-02, preview2-26130-01, preview2-26130-01, master-20180130-0046, respectively (master) Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-02, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively (master) Jan 30, 2018
@dotnet-maestro-bot dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 55f388b to 1e3be52 Compare January 30, 2018 13:43
@dotnet-maestro-bot
Copy link
Author

Discarded 1e3be52: Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-02, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively

CI Status: 6:x: 3:heavy_check_mark: (click to expand)
  • ❌ Alpine.3.6 x64 Debug Build Build finished. Details
  • ❌ CentOS7.1 x64 Checked Innerloop Build and Test Build finished. Details
  • ❌ OSX10.12 x64 Checked Innerloop Build and Test.* Build finished. Details
  • ❌ Tizen armel Cross Checked Innerloop Build and Test Build finished. Details
  • ❌ Windows_NT x64 Checked Innerloop Build and Test Build finished. Details
  • ❌ Windows_NT x86 Checked Innerloop Build and Test Build finished. Details
  • ✔️ license/cla All CLA requirements met. Details
  • ✔️ Windows_NT x64 Formatting Build finished. Details
  • ✔️ WIP ready for review Details

@dotnet-maestro-bot dotnet-maestro-bot changed the title Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-02, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively (master) Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively (master) Jan 30, 2018
@dotnet-maestro-bot dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 1e3be52 to 09218ae Compare January 30, 2018 17:55
@joperezr
Copy link
Member

CI is failing because buildtools, since the update will require extra changes I'm working on right now. I'll send out a separate PR for that and unblock this one.

@dotnet-maestro-bot
Copy link
Author

Discarded 09218ae: Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively

CI Status: 3:x: 9:hourglass: 3:heavy_check_mark: (click to expand)
  • ❌ Alpine.3.6 x64 Debug Build Build finished. Details
  • ❌ CentOS7.1 x64 Debug Innerloop Build Build finished. Details
  • ❌ Ubuntu arm64 Cross Debug Innerloop Build Build finished. Details
  • ⌛ CentOS7.1 x64 Checked Innerloop Build and Test Started. Details
  • ⌛ OSX10.12 x64 Checked Innerloop Build and Test.* Started. Details
  • ⌛ Tizen armel Cross Checked Innerloop Build and Test Triggered. (18/25 on ubuntu1404-20170120)
  • ⌛ Ubuntu x64 Checked Innerloop Build and Test.* Started. Details
  • ⌛ Ubuntu x64 Formatting Started. Details
  • ⌛ Windows_NT x64 Checked Innerloop Build and Test Started. Details
  • ⌛ Windows_NT x64 Formatting Started. Details
  • ⌛ Windows_NT x86 Checked Innerloop Build and Test Started. Details
  • ⌛ Windows_NT x86 Release Innerloop Build and Test Started. Details
  • ✔️ CROSS Check Build finished. Details
  • ✔️ license/cla All CLA requirements met. Details
  • ✔️ WIP ready for review Details

@dotnet-maestro-bot dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 09218ae to 8e37009 Compare January 30, 2018 18:13
@joperezr
Copy link
Member

Buildtools update handled by: #16101

@joperezr
Copy link
Member

The remaining failures are not buildtools related, they seem to be caused by the corefx ingestion. cc: @jkotas @stephentoub

@jkotas
Copy link
Member

jkotas commented Jan 30, 2018

'Span' does not contain a definition for 'DangerousCreate'

@ianhays This is fallout from your change. Could you please fix amend this PR with a change to fix these build breaks?

@dotnet-maestro-bot
Copy link
Author

Couldn't update this pull request: Head commit author 'Jose Perez Rodriguez' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-05, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively'

@jkotas jkotas mentioned this pull request Jan 30, 2018
Closed
@dotnet-maestro-bot
Copy link
Author

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-05, preview2-26130-05, preview2-26130-01, master-20180130-1600, respectively'

@dotnet-maestro-bot
Copy link
Author

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02431-01, preview2-26131-01, preview2-26130-01, master-20180130-1600, respectively'

1 similar comment
@dotnet-maestro-bot
Copy link
Author

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02431-01, preview2-26131-01, preview2-26130-01, master-20180130-1600, respectively'

@ianhays
Copy link

ianhays commented Jan 31, 2018

Still seeing the same issues from #16086 with CreateSpan missing.

@jkotas
Copy link
Member

jkotas commented Jan 31, 2018

The perf tests are build against .NET Standard 1.4 for some reason: https://github.com/dotnet/coreclr/blob/master/tests/src/JIT/config/benchmark/benchmark.csproj#L5

CreateSpan APIs are .NET Core 2.1 only, and that's why it cannot find them.

I would recommend putting the CreateSpan benchmark under #if false to get this through, and open issue on it. I am not sure what would be the perf team preference to deal with this.

cc @valenis

@dotnet-maestro-bot
Copy link
Author

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02431-02, preview2-26131-01, preview2-26130-01, master-20180130-1600, respectively'

@dotnet-maestro-bot
Copy link
Author

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02431-02, preview2-26131-01, preview2-26131-01, master-20180130-1600, respectively'

@dotnet-maestro-bot
Copy link
Author

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02431-02, preview2-26131-01, preview2-26131-01, master-20180131-0033, respectively'

@dotnet-maestro-bot
Copy link
Author

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02431-02, preview2-26131-05, preview2-26131-01, master-20180131-0033, respectively'

@dotnet-maestro-bot
Copy link
Author

Couldn't update this pull request: Head commit author 'Ian Hays' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02431-02, preview2-26131-05, preview2-26131-05, master-20180131-0033, respectively'

@ianhays
Copy link

ianhays commented Jan 31, 2018

@jkotas @joperezr would one of you mind please turning off the CreateSpan perf tests for me? I'm out sick.

@jkotas
Copy link
Member

jkotas commented Jan 31, 2018

I will take care of it.

@jkotas jkotas force-pushed the master-UpdateDependencies branch from 6181db1 to ddc88f3 Compare January 31, 2018 17:33
@dotnet-maestro-bot
Copy link
Author

Couldn't update this pull request: Head commit author 'Jan Kotas' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreFx, PgoData to preview2-02431-04, preview2-26131-05, preview2-26131-05, master-20180131-0033, respectively'

@jkotas jkotas merged commit a6d7f16 into dotnet:master Jan 31, 2018
dotnet-bot pushed a commit to dotnet/corefx that referenced this pull request Jan 31, 2018
@jkotas @dotnet-bot
Merge pull request dotnet/coreclr#16091 from dotnet-maestro-bot/maste…
cbca829 
…r-UpdateDependencies

Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively (master)

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
jkotas added a commit to dotnet/corefx that referenced this pull request Feb 1, 2018
@jkotas
Merge pull request dotnet/coreclr#16091 from dotnet-maestro-bot/maste…
26a505f 
…r-UpdateDependencies

Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively (master)

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot pushed a commit to dotnet/corert that referenced this pull request Feb 2, 2018
@jkotas @dotnet-bot
Merge pull request dotnet/coreclr#16091 from dotnet-maestro-bot/maste…
07f4023 
…r-UpdateDependencies

Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively (master)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas added a commit to dotnet/corert that referenced this pull request Feb 2, 2018
@jkotas
Merge pull request dotnet/coreclr#16091 from dotnet-maestro-bot/maste…
497acea 
…r-UpdateDependencies

Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02430-04, preview2-26130-05, preview2-26130-01, master-20180130-0046, respectively (master)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
AndyAyersMS added a commit to AndyAyersMS/coreclr that referenced this pull request Feb 27, 2018
@AndyAyersMS
Re-enable parts of SpanBench
7ce28a8 
A few parts of SpanBench were disabled in dotnet#16091 as we were compiling the
benchmarks with more restrictive netstandard versions and some APIs were
moved to be netcoreapp 2.1 only.

With the advent of dotnet#16378 we've removed those restrictions so the tests can
be re-enabled.
@AndyAyersMS AndyAyersMS mentioned this pull request Feb 27, 2018
Closed
@jkotas jkotas mentioned this pull request Jan 31, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dotnet-maestro-bot @joperezr @jkotas @ianhays