Simplify test dependencies for benchmarks #16378
Conversation
Remove the special benchmark configs and update benchmark projects accordingly. Also update other random projects that were referencing benchmark configs. Benchmarks now build against netstandard 2.0. Addresses #14124, #16126.
AndyAyersMS
added
the
* NO MERGE *
|
@jorive please look this over -- preliminary. Want to get some wider testing as things build ok locally. Tried updating xunit to 2.2.0 without success; we can do that later I suppose. |
|
Making sure something runs the pri-1s w/o too many exclusions... @dotnet-bot test Windows_NT x64 Checked jitsse2only |
|
Ok, maybe the noSSE wasn't the best way to run all the pri-1 tests. Looks like it has what are likely unrelated issues. @BruceForstall @jashook I can't see any way to just run all the pri-1 tests that doesn't also run some kind of stress mode. Am I missing something? In the meantime let's give zap disable a try... @dotnet-bot test Windows_NT x64 Checked zapdisable |
|
Maybe "Windows_NT x64 Build and Test" and "Windows_NT x86 Checked Build and Test"? I think for arm/arm64/armlb the pri-1 contain the work "normal" instead of "innerloop". |
|
@fiigii @tannergooding these "sse2 only" failures might be worth a closer look. |
A quick grep looks to be code size estimation issues. Possibly related to the recent changes to support 4-byte SSE4 instructions. |
|
Note there are ~2300 warnings for pri-1 tests, but for the most part these seem to match what was there before. Most of them are bogus or duplicate project includes. Pri-0 test build generates 61 warnings in managed code (and some in native code too). These too look like they are pre-existing. |
|
@AndyAyersMS, I see the problem. We have two ways of tracking SSE4 support ( |
|
@AndyAyersMS, as Bruce mentioned @dotnet-bot test Windows_NT x64 Build and Test |
|
The x64 full pri 1 run timed out after the windows test run, when building linux bits. So I don't see a need to rerun. @jorive PTAL |
|
@AndyAyersMS LGTM if there is no need to run these benchmarks in |
|
@jorive I don't see us back porting this to 1.1. We can run more or less the same benchmarks there in their current form. |
|
@AndyAyersMS OK, sounds good. |
|
|
AndyAyersMS
removed
the
* NO MERGE *
|
Double checking this hasn't gone stale: @dotnet-bot test this please |
|
@dotnet-bot test Windows_NT x64 Build and Test |
|
@dotnet-bot test Windows_NT x64 Checked jitsse2only |
|
@dotnet-bot test Windows_NT x86 Checked Build and Test |
A few parts of SpanBench were disabled in dotnet#16091 as we were compiling the benchmarks with more restrictive netstandard versions and some APIs were moved to be netcoreapp 2.1 only. With the advent of dotnet#16378 we've removed those restrictions so the tests can be re-enabled.
|
Reverted via #16647. |
Remove the special benchmark configs and update benchmark projects accordingly.
Also update other random projects that were referencing benchmark configs.
Benchmarks now build against netstandard 2.0.
Addresses #14124, #16126.