This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Revert "Debugger api to set a breakpoint on offset 0 of all methods" #16300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cd3f6e7.
…otnet#15819)" This reverts commit 3d689d0.
|
@davmason I am reverting your change because of it broke the build on OSX. The OSX leg on your PR was clearly failing:
Please do not merge without attributing CI failures to know https://github.com/dotnet/coreclr/issues?q=is%3Aissue+is%3Aopen+label%3Ablocking-clean-ci issues. |
|
How did you decide that this PR caused OSX problems? As I see from pr triggered OSX several jobs before the original PR was merged also had failed. Please return this fix back. |
|
The main change was added back with a fix for the build break in #16303 already. However, the follow up fix for the build warning was not. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduced OSX build break.