This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Moved extensions.cs to shared folder in coreclr #16459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
suggested changes
Feb 20, 2018
|
|
||
| namespace System.Globalization | ||
| { | ||
| public static class GlobalizationExtensions |
There was a problem hiding this comment.
The file should be called GlobalizationExtensions.cs to match coding conventions.
| } | ||
| } | ||
|
|
||
| internal sealed class CultureAwareComparer : StringComparer |
There was a problem hiding this comment.
This should be deleted because of we want to use the CultureAwareComparer that is in CoreLib already.
There was a problem hiding this comment.
@Anipik you need to delete CultureAwareComparer from here and introduce a new constructor which takes CompareInfo in https://github.com/dotnet/coreclr/blob/master/src/mscorlib/shared/System/StringComparer.cs#L175
In reply to: 169498383 [](ancestors = 169498383)
jkotas
approved these changes
Feb 21, 2018
tarekgh
approved these changes
Feb 21, 2018
Anipik
commented
Feb 21, 2018
| private CompareOptions _options; | ||
|
|
||
| internal CultureAwareComparer(CultureInfo culture, CompareOptions compareOptions) | ||
| internal CultureAwareComparer(CultureInfo culture, CompareOptions compareOptions) : this(culture.CompareInfo, compareOptions) { } |
There was a problem hiding this comment.
@jkotas should we change all of these to options for consistency ?
|
@jkotas @danmosemsft should I go ahead and merge this one ? |
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Feb 21, 2018
* Moved extensions.cs to shared folder * added to shared to projItems * Added new constructor * Parameter Named Changed Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Feb 21, 2018
* Moved extensions.cs to shared folder * added to shared to projItems * Added new constructor * Parameter Named Changed Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Feb 21, 2018
* Moved extensions.cs to shared folder * added to shared to projItems * Added new constructor * Parameter Named Changed Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Anipik
added a commit
to dotnet/corefx
that referenced
this pull request
Feb 21, 2018
* Moved extensions.cs to shared folder * added to shared to projItems * Added new constructor * Parameter Named Changed Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
kbaladurin
pushed a commit
to kbaladurin/corert
that referenced
this pull request
Mar 15, 2018
* Moved extensions.cs to shared folder * added to shared to projItems * Added new constructor * Parameter Named Changed Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/corefx#27099