This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Make member visibility first accross corlib #16836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Mar 8, 2018
danmoseley
reviewed
Mar 8, 2018
| { | ||
| return InternalToObject(&value); | ||
| } | ||
|
|
||
| [MethodImplAttribute(MethodImplOptions.InternalCall)] | ||
| internal unsafe extern static Object InternalToObject(void* value); | ||
| internal static extern unsafe Object InternalToObject(void* value); |
There was a problem hiding this comment.
We don't seem to specify ordering beyond visibility first. Seems like we're settling on something.
It reminds me of https://en.wikipedia.org/wiki/Adjective#Order
There was a problem hiding this comment.
The coding guidelines specify order for readonly. For the unspecified ones, I have unified them on the order that majority of the code in corefx has been using.
danmoseley
approved these changes
Mar 8, 2018
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Mar 8, 2018
Mechanical find&replace to match https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Mar 8, 2018
Mechanical find&replace to match https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Mar 8, 2018
…5518) Mechanical find&replace to match https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Mar 8, 2018
Mechanical find&replace to match https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
kbaladurin
pushed a commit
to kbaladurin/corert
that referenced
this pull request
Mar 15, 2018
…otnet#5518) Mechanical find&replace to match https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mechanical find&replace to match https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md