This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enable partially implemented Intel HW intrinsics ISAs - CoreCLR part of changes #17184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2018
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test |
|
@CarolEidt @eerhardt @fiigii @tannergooding PTAL - PR is ready for review. |
| // | ||
| bool Compiler::isFullyImplmentedISAClass(InstructionSet isa) | ||
| { | ||
| switch (isa) | ||
| { | ||
| case InstructionSet_SSE42: |
There was a problem hiding this comment.
nit: It might be good to split these into three logical groups:
// These ISAs have no implementation
case InstructionSet_AES:
case InstructionSet_BMI1:
case InstructionSet_BMI2:
case InstructionSet_FMA:
case InstructionSet_PCLMULQDQ:
return false;
// These ISAs are partially implemented
case InstructionSet_AVX:
case InstructionSet_AVX2:
case InstructionSet_SSE42:
return true;
// These ISAs are fully implemented
case InstructionSet_SSE:
case InstructionSet_SSE2:
case InstructionSet_SSE3:
case InstructionSet_SSSE3:
case InstructionSet_SSE41:
case InstructionSet_LZCNT:
case InstructionSet_POPCNT:
return true;
eerhardt
approved these changes
Mar 24, 2018
|
Test Tizen armel Cross Checked Innerloop Build and Test |
|
@eerhardt @tannergooding @CarolEidt PTAL Addressed code review feedback - test failure is due to known segfault error on Tizen |
fiigii
approved these changes
Mar 26, 2018
|
Can we merge this PR? Some test work needs this change. |
|
@tannergooding @CarolEidt Ping PTAL |
eerhardt
approved these changes
Mar 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is a first step to implement https://github.com/dotnet/corefx/issues/28363 and it replaces #17134