This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enable partially implemented Intel HW intrinsics ISAs - CoreFX part #28443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CarolEidt @eerhardt @fiigii @tannergooding PTAL - PR is ready for review. |
eerhardt
reviewed
Mar 24, 2018
| @@ -342,10 +326,6 @@ public static class Avx | |||
| public static unsafe Vector128<double> MaskLoad(double* address, Vector128<ulong> mask) { throw null; } | |||
| public static unsafe Vector256<float> MaskLoad(float* address, Vector256<uint> mask) { throw null; } | |||
| public static unsafe Vector256<double> MaskLoad(double* address, Vector256<ulong> mask) { throw null; } | |||
| public static unsafe void MaskStore(float* address, Vector128<float> mask, Vector128<uint> source) { throw null; } | |||
There was a problem hiding this comment.
@fiigii - we had a discussion about these methods right? You wanted to change the type of the 3rd parameter. Are these not yet implemented?
There was a problem hiding this comment.
These methods are not implemented
|
Test Linux x64 Release Build |
|
@dotnet-bot test Linux x64 Release Build |
eerhardt
approved these changes
Mar 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a CoreFX part of dotnet/coreclr#17184
Fixes #28363