Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Disable failing BestFitMapping tests #22438

Merged
BruceForstall merged 1 commit into from
Feb 6, 2019
Merged

Disable failing BestFitMapping tests #22438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,18 @@
<ExcludeList Include="$(XunitTestBinBase)/baseservices/varargs/varargsupport_r/*">
<Issue>Varargs supported on this platform</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/PInvoke/BestFitMapping/Char/AFT_PFT/AFT_PFT/*">
Copy link
Member

@jkotas jkotas Feb 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this disabling these tests completely? Do we have a way to disable tests for JIT stress only?

Copy link
Author

@BruceForstall BruceForstall Feb 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it disables them completely (for the specific conditions, so Windows x86, Windows x64).

We can disable for ALL platforms for JIT stress by changing their project files to include <JitOptimizationSensitive>true</JitOptimizationSensitive>, but that is better used for tests that are really incompatible, not bugs that are hopefully fixed quickly. Plus it means changing more files.

Copy link

@jashook jashook Feb 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can set true for a specific arch/os by adding a condition. It is ugly, but possible.

Copy link

@jashook jashook Feb 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going forward, I believe it would be better to add the following to the test's csproj:

<!-- GH Issue 22436 -->
<JitOptimizationSensitive Condition="'$(OSGroup)' == 'Windows_NT' And '$(BuildArch)' == 'x86'">true</JitOptimizationSensitive>

We have the knob, it seems correct to use it.

<Issue>22436</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/PInvoke/BestFitMapping/Char/Assembly_False_False/Assembly_False_False/*">
<Issue>22436</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/PInvoke/BestFitMapping/LPStr/AFT_PFT/AFT_PFT/*">
<Issue>22436</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/PInvoke/BestFitMapping/LPStr/Assembly_False_False/Assembly_False_False/*">
<Issue>22436</Issue>
</ExcludeList>
</ItemGroup>

<!-- Windows x86 specific excludes -->
Expand Down Expand Up @@ -280,6 +292,12 @@
<ExcludeList Include="$(XunitTestBinBase)/baseservices/varargs/varargsupport_r/*">
<Issue>Varargs supported on this platform</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/PInvoke/BestFitMapping/Char/AFT_PFT/AFT_PFT/*">
<Issue>22436</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Interop/PInvoke/BestFitMapping/LPStr/AFT_PFT/AFT_PFT/*">
<Issue>22436</Issue>
</ExcludeList>
</ItemGroup>

<!-- Windows arm32 specific excludes -->
Expand Down