Disable failing BestFitMapping tests #22438
Conversation
Tests: ``` Interop\PInvoke\BestFitMapping\Char\AFT_PFT\AFT_PFT\AFT_PFT.cmd Interop\PInvoke\BestFitMapping\Char\Assembly_False_False\Assembly_False_False\Assembly_False_False.cmd Interop\PInvoke\BestFitMapping\LPStr\AFT_PFT\AFT_PFT\AFT_PFT.cmd Interop\PInvoke\BestFitMapping\LPStr\Assembly_False_False\Assembly_False_False\Assembly_False_False.cmd ``` Tracked by https://github.com/dotnet/coreclr/issues/22436
|
@dotnet-bot test Windows_NT x64 Checked jitstress2 |
|
@dotnet/jit-contrib |
| <ExcludeList Include="$(XunitTestBinBase)/baseservices/varargs/varargsupport_r/*"> | ||
| <Issue>Varargs supported on this platform</Issue> | ||
| </ExcludeList> | ||
| <ExcludeList Include="$(XunitTestBinBase)/Interop/PInvoke/BestFitMapping/Char/AFT_PFT/AFT_PFT/*"> |
There was a problem hiding this comment.
Is this disabling these tests completely? Do we have a way to disable tests for JIT stress only?
There was a problem hiding this comment.
Yes, it disables them completely (for the specific conditions, so Windows x86, Windows x64).
We can disable for ALL platforms for JIT stress by changing their project files to include <JitOptimizationSensitive>true</JitOptimizationSensitive>, but that is better used for tests that are really incompatible, not bugs that are hopefully fixed quickly. Plus it means changing more files.
There was a problem hiding this comment.
I believe we can set true for a specific arch/os by adding a condition. It is ugly, but possible.
There was a problem hiding this comment.
Going forward, I believe it would be better to add the following to the test's csproj:
<!-- GH Issue 22436 -->
<JitOptimizationSensitive Condition="'$(OSGroup)' == 'Windows_NT' And '$(BuildArch)' == 'x86'">true</JitOptimizationSensitive>
We have the knob, it seems correct to use it.
AaronRobinsonMSFT
added
the
disabled-test
|
PR #22731 re-enables these tests |
|
These tests have been re-enabled |
…lingXarchTests Disable failing BestFitMapping tests Commit migrated from dotnet/coreclr@9e9049a
6 participants
Tests:
Tracked by https://github.com/dotnet/coreclr/issues/22436