This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix Issue 22436 - noway_assert 'expTyp == cseLclVarTyp' in optcse.cpp #22731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now allow TYP_BYREF to be compatible with TYP_I_IMPL when performing CSE substitutions. Re-enable the failing BestFitMapping interop tests
Author
|
@dotnet-bot test Windows_NT x64 Checked Innerloop jitstress2 Build and Test |
Author
|
@dotnet-bot test Windows_NT x64 Checked jitstress2 |
briansull
changed the title
src/jit/optcse.cpp
Outdated
| // | ||
| bool IsCompatibleType(var_types cseLclVarTyp, var_types expTyp) | ||
| { | ||
| // Excat type match is the expected case |
AndyAyersMS
approved these changes
Feb 21, 2019
Member
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
You need braces after your ifs.
We are going to develop a better strategy for these mixed byref/nint cases someday, and when we do, we might want to go back to being strict here.
Author
|
@AndyAyersMS Agreed |
Author
|
@dotnet-bot test Windows_NT x64 Checked jitstress2 |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix Issue 22436 - noway_assert 'expTyp == cseLclVarTyp' in optcse.cpp Commit migrated from dotnet/coreclr@bb0c2df
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow TYP_BYREF to be compatible with TYP_I_IMPL when performing CSE substitutions.
Re-enable the failing BestFitMapping interop tests