This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
More CoreLib code cleanup #26104
Merged
More CoreLib code cleanup #26104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
added
the
* NO MERGE *
stephentoub
force-pushed
the
morestylecop
branch
from
83a6962
to
b99887e
Compare
stephentoub
removed
the
* NO MERGE *
stephentoub
force-pushed
the
morestylecop
branch
from
b99887e
to
c5a2e17
Compare
Wraith2
reviewed
Aug 13, 2019
AaronRobinsonMSFT
approved these changes
Aug 13, 2019
I used the auto-fix and then undid changes in areas where the fields were potentially mutated in native, e.g. I undid many of the changes in reflection. We can revisit those individually later.
stephentoub
force-pushed
the
morestylecop
branch
from
c5a2e17
to
bd92f17
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In between-meetings cleanup guided by various analyzers (and mostly fixed via auto-fixers).