Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused private parameters in SPC #63015

Merged
merged 9 commits into from
Feb 12, 2022
Merged

Conversation

marek-safar
Copy link
Contributor

and remove related dead code

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

and remove related dead code
@ghost
Copy link

ghost commented Dec 23, 2021

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

and remove related dead code

Author: marek-safar
Assignees: marek-safar
Labels:

area-System.Runtime

Milestone: -

@jkotas
Copy link
Member

jkotas commented Dec 28, 2021

Many instances of this stylecop warning were cleaned up in dotnet/coreclr#26104, but the enforcement was not enabled enforcement as part of that PR. cc @stephentoub

internal static bool CanSetMaxIOCompletionThreads(int ioCompletionThreads) => true;
#pragma warning restore IDE0060

[Conditional("unnecessary")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the similar cases are partial methods. Is there are reason why these are Conditional("unnecessary") and not partial methods?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not private hence we cannot use a partial method without an implementation.

@stephentoub
Copy link
Member

Many instances of this stylecop warning were cleaned up in dotnet/coreclr#26104, but the enforcement was not enabled enforcement as part of that PR. cc @stephentoub

Because there was a lot left to do across the repo :)

@stephentoub
Copy link
Member

stephentoub commented Jan 3, 2022

@marek-safar, are you planning to fix all occurrences of this across the repo and enable the rule?

Otherwise, I'm not a big fan of adding a lot of suppressions for a rule we explicitly disable.

@marek-safar
Copy link
Contributor Author

are you planning to fix all occurrences of this across the repo and enable the rule?

I'd like in 2022 ;-)

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marek-safar marek-safar merged commit 47bcd1a into dotnet:main Feb 12, 2022
@marek-safar marek-safar deleted the ide0060 branch February 12, 2022 17:44
@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants