This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Mark methods specially handled in JitInterface Intrinsic #26209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For CPAOT compiler's sake.
jkotas
approved these changes
Aug 16, 2019
|
Maybe also replace |
jkotas
reviewed
Aug 20, 2019
| @@ -141,6 +141,7 @@ public static T CreateInstance<T>() | |||
| return (T)((RuntimeType)typeof(T)).CreateInstanceDefaultCtor(publicOnly: true, skipCheckThis: true, fillCache: true, wrapExceptions: true); | |||
| } | |||
|
|
|||
| [System.Runtime.CompilerServices.Intrinsic] | |||
There was a problem hiding this comment.
This should not be marked as Intrinsic. Instead, CreateInstance<T>() should be marked as Intrinsic, I think.
@jkotas - sorry, missed this comment. Only noticed it now when I came back to delete the branch. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…clr#26209) * Mark methods specially handled in JitInterface Intrinsic For CPAOT compiler's sake. Commit migrated from dotnet/coreclr@2173d92
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CPAOT compiler's sake.