This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[Release/2.1] Respect profiler provided IL maps (Port #25802) #27295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entedCodeMap (dotnet#25802) * Fix GetSequencePoints when profiler provides mapping via SetILInstrumentedCodeMap * code review feedback
davmason
added
area-Diagnostics
Servicing-consider
davmason
changed the title
|
Thank you for your contribution. As announced in dotnet/coreclr#27549 this repository will be moving to dotnet/runtime on November 13. If you would like to continue working on this PR after this date, the easiest way to move the change to dotnet/runtime is:
|
|
Please ignore my previous comment. Since this PR is not targeting master branch, no action would be needed here. Thanks. |
|
We are currently waiting on positive acknowledgement from the customer that this fully addresses their issue. Thank you to everyone involved. |
|
I received validation from the customer today that this fixes the issue he was seeing. It is ready for review now. |
leecow
added
Servicing-approved
mmitche
pushed a commit
that referenced
this pull request
Nov 25, 2019
* Update CoreClr, CoreFx to servicing-28207-04, servicing-28208-01, respectively (#27899) * update branding for 2.1 (#27914) * Fix GetSequencePoints when profiler provides mapping via SetILInstrumentedCodeMap (#27295) Port #25802 to release/2.1 * Use MicrosoftSHA2 for DAC signing (#27933) * Use MicrosoftSHA2 for DAC signing * Fix DAC name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a profiler modifies IL it can also provide an updated source->IL map so that the debugger (or potentially any other consumer of the source->IL map) can correctly process the updated function. There was a type introduced in 2.1 that effectively makes the runtime ignore the profiler provided maps when the debugger asks for them.
Customer Impact
Debugging is broken for profiler modified functions, this was reported by a customer that uses the profiler APIs for a unit test framework.
Regression?
It is a regression from desktop behavior, and preventing the customer's profiler from working with apps targeting 2.1. Profiling was not supported on core before 2.1 so it is not technically a regression on core.
Risk
Very low risk, this code path is only used by the debugger/DAC and the fix is easy to reason about.