This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Use MicrosoftSHA2 for DAC signing #27933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyosjs
force-pushed
the
juhoyosa/fix-2.1-dacsign
branch
from
b2c67a3 to
63d53ef
Compare
|
After this both crossarch and regular DAC request for MicrosoftSHA2 signatures.
|
mmitche
approved these changes
Nov 24, 2019
mmitche
pushed a commit
that referenced
this pull request
Nov 25, 2019
* Update CoreClr, CoreFx to servicing-28207-04, servicing-28208-01, respectively (#27899) * update branding for 2.1 (#27914) * Fix GetSequencePoints when profiler provides mapping via SetILInstrumentedCodeMap (#27295) Port #25802 to release/2.1 * Use MicrosoftSHA2 for DAC signing (#27933) * Use MicrosoftSHA2 for DAC signing * Fix DAC name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DAC can't be signed with a 400 cert like all other DLLs. There's a requirement to have a dual Sha signature for Watson scenarios.