This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update NS2.0 Apicompat baseline #15765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
force-pushed
the
UpdateNS2Baseline
branch
from
01f2a50 to
a3b141a
Compare
ericstj
reviewed
Feb 3, 2017
external/netfx/netfx.depproj
Outdated
| @@ -27,10 +27,14 @@ | |||
| <ItemGroup> | |||
| <TargetingPackReference Include="mscorlib" /> | |||
| <TargetingPackReference Include="System" /> | |||
| <TargetingPackReference Include="System.ComponentModel.Composition" /> | |||
There was a problem hiding this comment.
These need to go in shims.proj.
Please don't add filtering back to this project unless you do a full BuildAllConfigurations=true build
There was a problem hiding this comment.
Yep I've moved those as part of resolving this.
Update the NS2.0 package to fix a couple issues in the shims. Added more shims to the list we need for .NET Core compat with NS2.0 The remaining System.Transactions issues will be fixed once we rename that assembly as part of https://github.com/dotnet/corefx/issues/15259
weshaggard
force-pushed
the
UpdateNS2Baseline
branch
from
a3b141a to
d902b1c
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Update NS2.0 Apicompat baseline Commit migrated from dotnet/corefx@8c96c4e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the NS2.0 package to fix a couple issues in the shims.
Added more shims to the list we need for .NET Core compat with NS2.0
The remaining System.Transactions issues will be fixed once we rename
that assembly as part of https://github.com/dotnet/corefx/issues/15259
cc @ericstj @joperezr