Update CoreClr, CoreSetup to preview2-26216-09, preview2-26216-04, respectively (master)

[dotnet-maestro-bot]

No description provided.

[ahsonkhan]

These tests are failing - System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests - ValidateAgainstBlobs:
https://mc.dot.net/#/user/dotnet-maestro-bot/pr~2Fjenkins~2Fdotnet~2Fcorefx~2Fmaster~2F/test~2Ffunctional~2Fcli~2F/40b9a881d11975580f73a62093345f46fd4a2673/workItem/System.Runtime.Serialization.Formatters.Tests

Any ideas why?

The stored blob for type System.Collections.Specialized.ListDictionary is outdated and needs to be updated.

-------------------- Stored blob ---------------------
Encoded: AAEAAAD/////AQAAAAAAAAAMAgAAAElTeXN0ZW0sIFZlcnNpb249NC4wLjAuMCwgQ3VsdHVyZT1uZXV0cmFsLCBQdWJsaWNLZXlUb2tlbj1iNzdhNWM1NjE5MzRlMDg5BQEAAAAtU3lzdGVtLkNvbGxlY3Rpb25zLlNwZWNpYWxpemVkLkxpc3REaWN0aW9uYXJ5BAAAAARoZWFkB3ZlcnNpb24FY291bnQIY29tcGFyZXIEAAADPFN5c3RlbS5Db2xsZWN0aW9ucy5TcGVjaWFsaXplZC5MaXN0RGljdGlvbmFyeStEaWN0aW9uYXJ5Tm9kZQIAAAAICBtTeXN0ZW0uQ3VsdHVyZUF3YXJlQ29tcGFyZXICAAAACQMAAAACAAAAAgAAAAkEAAAABQMAAAA8U3lzdGVtLkNvbGxlY3Rpb25zLlNwZWNpYWxpemVkLkxpc3REaWN0aW9uYXJ5K0RpY3Rpb25hcnlOb2RlAwAAAANrZXkFdmFsdWUEbmV4dAICBDxTeXN0ZW0uQ29sbGVjdGlvbnMuU3BlY2lhbGl6ZWQuTGlzdERpY3Rpb25hcnkrRGljdGlvbmFyeU5vZGUCAAAAAgAAAAYFAAAABGtleTEGBgAAAAZ2YWx1ZTEJBwAAAAQEAAAAG1N5c3RlbS5DdWx0dXJlQXdhcmVDb21wYXJlcgIAAAAMX2NvbXBhcmVJbmZvC19pZ25vcmVDYXNlAwAgU3lzdGVtLkdsb2JhbGl6YXRpb24uQ29tcGFyZUluZm8BCQgAAAAAAQcAAAADAAAABgkAAAAEa2V5eAYKAAAABnZhbHVleAoECAAAACBTeXN0ZW0uR2xvYmFsaXphdGlvbi5Db21wYXJlSW5mbwMAAAAGbV9uYW1lDW1fU29ydFZlcnNpb24HY3VsdHVyZQEDACBTeXN0ZW0uR2xvYmFsaXphdGlvbi5Tb3J0VmVyc2lvbggGCwAAAAAKfwAAAAs=
Decoded: \0\x01\0\0\0����\x01\0\0\0\0\0\0\0\f\x02\0\0\0ISystem, Version=0.0.0.0 Culture=neutral, PublicKeyToken=b77a5c561934e089\x05\x01\0\0\0-System.Collections.Specialized.ListDictionary\x04\0\0\0\x04head\aversion\x05count\bcomparer\x04\0\0\x03<System.Collections.Specialized.ListDictionary+DictionaryNode\x02\0\0\0\b\b\x1bSystem.CultureAwareComparer\x02\0\0\0\t\x03\0\0\0\x02\0\0\0\x02\0\0\0\t\x04\0\0\0\x05\x03\0\0\0<System.Collections.Specialized.ListDictionary+DictionaryNode\x03\0\0\0\x03key\x05value\x04next\x02\x02\x04<System.Collections.Specialized.ListDictionary+DictionaryNode\x02\0\0\0\x02\0\0\0\x06\x05\0\0\0\x04key1\x06\x06\0\0\0\x06value1\t\a\0\0\0\x04\x04\0\0\0\x1bSystem.CultureAwareComparer\x02\0\0\0\f_compareInfo\v_ignoreCase\x03\0 System.Globalization.CompareInfo\x01\t\b\0\0\0\0\x01\a\0\0\0\x03\0\0\0\x06\t\0\0\0\x04keyx\x06\0\0\0\x06valuex\x04\b\0\0\0 System.Globalization.CompareInfo\x03\0\0\0\x06m_namem_SortVersion\aculture\x01\x03\0 System.Globalization.SortVersion\b\x06\v\0\0\0\0�\0\0\0\v

--------------- Runtime generated blob ---------------
Encoded: AAEAAAD/////AQAAAAAAAAAMAgAAAElTeXN0ZW0sIFZlcnNpb249NC4wLjAuMCwgQ3VsdHVyZT1uZXV0cmFsLCBQdWJsaWNLZXlUb2tlbj1iNzdhNWM1NjE5MzRlMDg5BQEAAAAtU3lzdGVtLkNvbGxlY3Rpb25zLlNwZWNpYWxpemVkLkxpc3REaWN0aW9uYXJ5BAAAAARoZWFkB3ZlcnNpb24FY291bnQIY29tcGFyZXIEAAADPFN5c3RlbS5Db2xsZWN0aW9ucy5TcGVjaWFsaXplZC5MaXN0RGljdGlvbmFyeStEaWN0aW9uYXJ5Tm9kZQIAAAAICBtTeXN0ZW0uQ3VsdHVyZUF3YXJlQ29tcGFyZXICAAAACQMAAAACAAAAAgAAAAkEAAAABQMAAAA8U3lzdGVtLkNvbGxlY3Rpb25zLlNwZWNpYWxpemVkLkxpc3REaWN0aW9uYXJ5K0RpY3Rpb25hcnlOb2RlAwAAAANrZXkFdmFsdWUEbmV4dAICBDxTeXN0ZW0uQ29sbGVjdGlvbnMuU3BlY2lhbGl6ZWQuTGlzdERpY3Rpb25hcnkrRGljdGlvbmFyeU5vZGUCAAAAAgAAAAYFAAAABGtleTEGBgAAAAZ2YWx1ZTEJBwAAAAQEAAAAG1N5c3RlbS5DdWx0dXJlQXdhcmVDb21wYXJlcgMAAAAMX2NvbXBhcmVJbmZvCF9vcHRpb25zC19pZ25vcmVDYXNlAwMAIFN5c3RlbS5HbG9iYWxpemF0aW9uLkNvbXBhcmVJbmZvI1N5c3RlbS5HbG9iYWxpemF0aW9uLkNvbXBhcmVPcHRpb25zAQkIAAAABPf///8jU3lzdGVtLkdsb2JhbGl6YXRpb24uQ29tcGFyZU9wdGlvbnMBAAAAB3ZhbHVlX18ACAAAAAAAAQcAAAADAAAABgoAAAAEa2V5eAYLAAAABnZhbHVleAoECAAAACBTeXN0ZW0uR2xvYmFsaXphdGlvbi5Db21wYXJlSW5mbwMAAAAGbV9uYW1lDW1fU29ydFZlcnNpb24HY3VsdHVyZQEDACBTeXN0ZW0uR2xvYmFsaXphdGlvbi5Tb3J0VmVyc2lvbggGDAAAAAAKfwAAAAs=
Decoded: \0\x01\0\0\0����\x01\0\0\0\0\0\0\0\f\x02\0\0\0ISystem, Version=0.0.0.0 Culture=neutral, PublicKeyToken=b77a5c561934e089\x05\x01\0\0\0-System.Collections.Specialized.ListDictionary\x04\0\0\0\x04head\aversion\x05count\bcomparer\x04\0\0\x03<System.Collections.Specialized.ListDictionary+DictionaryNode\x02\0\0\0\b\b\x1bSystem.CultureAwareComparer\x02\0\0\0\t\x03\0\0\0\x02\0\0\0\x02\0\0\0\t\x04\0\0\0\x05\x03\0\0\0<System.Collections.Specialized.ListDictionary+DictionaryNode\x03\0\0\0\x03key\x05value\x04next\x02\x02\x04<System.Collections.Specialized.ListDictionary+DictionaryNode\x02\0\0\0\x02\0\0\0\x06\x05\0\0\0\x04key1\x06\x06\0\0\0\x06value1\t\a\0\0\0\x04\x04\0\0\0\x1bSystem.CultureAwareComparer\x03\0\0\0\f_compareInfo\b_options\v_ignoreCase\x03\x03\0 System.Globalization.CompareInfo#System.Globalization.CompareOptions\x01\t\b\0\0\0\x04����#System.Globalization.CompareOptions\x01\0\0\0\avalue__\0\b\0\0\0\0\0\x01\a\0\0\0\x03\0\0\0\x06\0\0\0\x04keyx\x06\v\0\0\0\x06valuex\x04\b\0\0\0 System.Globalization.CompareInfo\x03\0\0\0\x06m_namem_SortVersion\aculture\x01\x03\0 System.Globalization.SortVersion\b\x06\f\0\0\0\0�\0\0\0\v
Expected: True
Actual:   False

  at System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests.SanityCheckBlob(Object obj, String[] blobs) in D:\j\workspace\windows-TGrou---f8ac6754\src\System.Runtime.Serialization.Formatters\tests\BinaryFormatterTests.cs:line 513
   at System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests.ValidateAndRoundtrip(Object obj, String[] blobs, Boolean isEqualityComparer) in D:\j\workspace\windows-TGrou---f8ac6754\src\System.Runtime.Serialization.Formatters\tests\BinaryFormatterTests.cs:line 74
   at System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests.ValidateAgainstBlobs(Object obj, String[] blobs) in D:\j\workspace\windows-TGrou---f8ac6754\src\System.Runtime.Serialization.Formatters\tests\BinaryFormatterTests.cs:line 54

cc @Anipik, @ViktorHofer, @danmosemsft, @joperezr

[Anipik]

Serialization for stringComparer has changed for netcoreapp2.1 so this test needs to be changed. The PR is up for it but hasnot yet merged in corefx

[Anipik]

I have fixed these 2 tests in #27051

[ahsonkhan]

I have fixed these 2 tests in #27051

I grabbed the test changes from ahsonkhan@bc8ef66 to unblock the CI. Thanks.

Edit:
I grabbed the test changes from ahsonkhan@c1ffef1 to unblock the CI (courtesy of @Anipik). Thanks.

[ahsonkhan]

@dotnet-bot test Alpine.3.6 x64 Debug Build

[dotnet-maestro-bot]

Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot'
Would have applied 'Update CoreClr, CoreSetup to preview2-26217-01, preview2-26216-04, respectively'

[ahsonkhan]

Anyone know what is causing this failure for Alpine3.6?
"error MSB3073: The command...exited with code 139"

https://ci3.dot.net/job/dotnet_corefx/job/master/job/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/2307/console

17:31:49 /mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/Tools/IL.targets(48,5): error MSB3073: The command "/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/Tools/ilasm/ilasm -QUIET -NOLOGO -DLL  -INCLUDE=include/netstandard -OUTPUT=/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/bin/obj/AnyOS.AnyCPU.Debug/System.Runtime.CompilerServices.Unsafe/netstandard/System.Runtime.CompilerServices.Unsafe.dll -KEY=/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/Tools/MSFT.snk System.Runtime.CompilerServices.Unsafe.il" exited with code 139. [/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.ilproj]

cc @dotnet/dnceng. @stephentoub

@dotnet-bot test Alpine.3.6 x64 Debug Build

[jonfortescue]

That's a segfault. We'll look into it to see if it's an issue with the build system.

[jonfortescue]

Looks like the segfault occurred in ILASM, which suggests to me that it's a bug with the Alpine assembler. I don't know who owns that, but those folks are who you're going to want to ping about this.

[AndyAyersMS]

ILASM is produced in CoreCLR and serviced by the jit team. cc @dotnet/jit-contrib

Do you have a crash dump or any other indication of where things go wrong?

[danmoseley]

Unforutnately dumpling is not working at present. We only know:

  Segmentation fault (core dumped)
/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/Tools/IL.targets(48,5): error MSB3073: The command "/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/Tools/ilasm/ilasm -QUIET -NOLOGO -DLL  -INCLUDE=include/netstandard -OUTPUT=/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/bin/obj/AnyOS.AnyCPU.Debug/System.Runtime.CompilerServices.Unsafe/netstandard/System.Runtime.CompilerServices.Unsafe.dll -KEY=/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/Tools/MSFT.snk System.Runtime.CompilerServices.Unsafe.il" exited with code 139. 

I recommend using the "repro" system to get a connection to an Alpine box on which you can run this command and get it under the debugger or get a dump.

[AndyAyersMS]

I don't see a repro link, unfortunately. So here's a pointer to the old leg; I am going to retry and see if this fails consistently.

@dotnet-bot retest Alpine.3.6 x64 Debug Build

[stephentoub]

Segmentation fault (core dumped)
/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/Tools/IL.targets(48,5): error MSB3073: The command "/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/Tools/ilasm/ilasm -QUIET -NOLOGO -DLL -INCLUDE=include/netstandard -OUTPUT=/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/bin/obj/AnyOS.AnyCPU.Debug/System.Runtime.CompilerServices.Unsafe/netstandard/System.Runtime.CompilerServices.Unsafe.dll -KEY=/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/Tools/MSFT.snk System.Runtime.CompilerServices.Unsafe.il" exited with code 139. [/mnt/j/workspace/dotnet_corefx/master/alpine-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/src/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.ilproj]

[ahsonkhan]

I don't see a repro link, unfortunately.

There is no repro link on ci3.

@dotnet/dnceng, @maririos

[Anipik]

Repro is not available for ci3 server

[dotnet-maestro-bot]

Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot'
Would have applied 'Update CoreClr, CoreSetup to preview2-26218-01, preview2-26217-03, respectively'

[dotnet-maestro-bot]

Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot'
Would have applied 'Update CoreClr, CoreSetup to preview2-26218-04, preview2-26218-01, respectively'

[dotnet-maestro-bot]

Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot'
Would have applied 'Update CoreClr, CoreSetup to preview2-26219-05, preview2-26218-03, respectively'

[AndyAyersMS]

Was able to repro the crash, so hopefully can get to the bottom of it. Here's the call stack:

[AndyAyersMS]

My best guess is that ILASM is crashing early in EEStartupHelper trying to chain the exception record, looks like perhaps TLS is not initialized the way this method expects.

[AndyAyersMS]

@janvorli any idea what might be going wrong? ILASM hasn't changed in a while so this looks like a build or runtime configuration issue.

[dotnet-maestro-bot]

Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot'
Would have applied 'Update CoreClr, CoreSetup to preview2-26220-01, preview2-26219-02, respectively'

[AndyAyersMS]

I built my own CHK ILASM (not sure if it's exactly what we get with official builds since I could not easily find what packages we use to build on alpine) and it hits an assert. So this might give some clues about what is going wrong above.

So maybe something wrong with the method that gets the current SP? Rebuilding with debug to see if it tells me more.

[dotnet-maestro-bot]

Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot'
Would have applied 'Update CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-26220-01, preview2-26220-01, beta-26220-01, beta-26220-01, respectively'

[dotnet-maestro-bot]

Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot'
Would have applied 'Update CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-26220-05, preview2-26220-01, beta-26220-01, beta-26220-01, respectively'

[sdmaclea]

@AndyAyersMS

The error you showed was a PAX error. An attempt was made to execute code which was writable, when it was not enabled.

@janvorli used paxctl -c -m corerun to enable this for corerun, because JIT is not marking executable pages as read-only. Not sure if ILASM should be executing writable code or not.

[dotnet-maestro-bot]

Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot'
Would have applied 'Update BuildTools, CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-02520-01, preview2-26220-05, preview2-26220-01, beta-26220-01, beta-26220-01, respectively'

[ahsonkhan]

I am going to close this PR so we can get new updates.

We will need to add this commit to the PR (ahsonkhan@c1ffef1) once the Alpine issue has been resolved.