Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@vcsjones
Copy link
Member

Fixes #35224

/cc @bartonjs @stephentoub

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@safern safern merged commit e8a88e8 into dotnet:master Feb 12, 2019
@safern
Copy link
Member

safern commented Feb 12, 2019

Merged since we were hitting failures in other PRs and these PR was green on both, Jenkins and Azure legs.

@vcsjones vcsjones deleted the 35224_ignore_require_ct branch February 12, 2019 01:05
@danmoseley
Copy link
Member

Thanks @vcsjones what do yo uthink about also changing to #if DEBUGGING_UNKNOWN_VALUE || DEBUG as @bartonjs suggested, so we can resolve this quicker next time?

@stephentoub
Copy link
Member

@danmosemsft, that change was already merged ;-)

@danmoseley
Copy link
Member

Yeah, I know, sometimes it's just a convenient place to ask questions..

@stephentoub
Copy link
Member

Yeah, I know, sometimes it's just a convenient place to ask questions..

No, I mean the #if DEBUGGING_UNKNOWN_VALUE || DEBUG change was already merged. It's already done.

@danmoseley
Copy link
Member

Ah - I see, in another PR. cool. thanks.

@karelz karelz added this to the 3.0 milestone Mar 18, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants