This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/2.1] Ignore CTRequired when building an X509 chain on macOS #35590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
approved these changes
Feb 26, 2019
danmoseley
reviewed
Feb 26, 2019
| } | ||
| else if (CFEqual(keyString, CFSTR("NonEmptySubject")) || CFEqual(keyString, CFSTR("GrayListedKey"))) | ||
| else if (CFEqual(keyString, CFSTR("NonEmptySubject")) || CFEqual(keyString, CFSTR("GrayListedKey")) || | ||
| CFEqual(keyString, CFSTR("CTRequired"))) |
Member
There was a problem hiding this comment.
Might be worth a comment indicating what CTRequired actually means, now you've satisfied yourself that it's not relevant to us.
stephentoub
approved these changes
Feb 26, 2019
vivmishra
added
Servicing-approved
|
Approved for 2.1.10 and 2.2.4. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #35246 to release/2.1 to prevent the new "CTRequired" errors from failing X509Chain builds on macOS.
Description
Recent change to macOS has caused a new error code to appear during X509Chain building. Since this error code has been identified as not having impact on the .NET X509Chain class, ignore it.
Customer Impact
Without this fix, customers who upgrade their macOS version and build X509Chains against certificates/certificate-authorities which result in the CTRequired code will get a CryptographicException due to the unmapped error.
Regression?
No, reaction to OS update.
Packaging reviewed?
Required shim library, no packaging impact.
Risk
Minimal
Fixes #35224