Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[release/2.1] Ignore CTRequired when building an X509 chain on macOS #35590

Merged
wtgodbe merged 1 commit into from
Mar 7, 2019
Merged

[release/2.1] Ignore CTRequired when building an X509 chain on macOS #35590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Native/Unix/System.Security.Cryptography.Native.Apple/pal_x509chain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,8 @@ static void MergeStatusCodes(CFTypeRef key, CFTypeRef value, void* context)
// It doesn't represent a new error code, and we're still getting the old ones, so
// just ignore it for now.
}
else if (CFEqual(keyString, CFSTR("NonEmptySubject")) || CFEqual(keyString, CFSTR("GrayListedKey")))
else if (CFEqual(keyString, CFSTR("NonEmptySubject")) || CFEqual(keyString, CFSTR("GrayListedKey")) ||
CFEqual(keyString, CFSTR("CTRequired")))
Copy link
Member

@danmoseley danmoseley Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth a comment indicating what CTRequired actually means, now you've satisfied yourself that it's not relevant to us.

{
// Not a "problem" that we report.
}
Expand Down