Remove UAP target

[ViktorHofer]

cc @safern @danmosemsft

[ViktorHofer]

I still need to figure out the harvesting story for the uap assets.

[ViktorHofer]

OK this should be ready now. Anybody wants to review the 1.4k file changes? 😫😫😫 @danmosemsft @stephentoub @ericstj @safern

[davidsh]

OK this should be ready now. Anybody wants to review the 1.4k file changes?

How did you modify 1.4k files in the first place? Did you use an automated tool of some kind? That's a lot of files to hand edit.

I would suggest that if it builds ok, then it should be merged. Then we can sort out issues (if any) later.

[ViktorHofer]

How did you modify 1.4k files in the first place? Did you use an automated tool of some kind? That's a lot of files to hand edit.

I did most of the changes by hand + a few regex replace patterns for the Configurations.props files and the <Configurations /> element in the csproj files.

[davidsh]

I did most of the changes by hand

Impressive!

I still think we should merge once the build looks good.

[ViktorHofer]

I think 50% of the changes were automated so it's probably not that impressive. But that proves how badly I want this change in ;)

[danmoseley]

For changes like this I usually pull them down and fiddle with grep to try to spot anomalous changes. Eg.,

git diff -b -U0 --diff-filter=d upstream/master..viktorhofer/removeuaptarget | \t\grep  -E "(^- |^\+ )" > out

Shows just the add/remove lines in files that weren't deleted, with no context. Then I will grep away in my editor diffs that I don't care about, like .*\<configurations.*\n or whatever until it's small enough to read.

[safern]

Other than my questions/comments, overall looks good.

[ViktorHofer]

@jkotas @stephentoub and I agreed offline that we remove all WinRT related files with this PR as the chance to bring them in their current state back is close to zero. One of the reasons for that is that more Win32 APIs are now allowed than back in 2017.

[ViktorHofer]

Number of tests before and after the change. The results match my assumption of having ~70k less test invocations because of the removal of the UWP leg.

Before

After