This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Initial SslStream stress app work #42560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
added
tenet-reliability
|
/azp run corefx-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/System.Net.Security/tests/StressTests/SslStress/Utils/PipeExtensions.cs
Outdated
Show resolved
Hide resolved
src/System.Net.Security/tests/StressTests/SslStress/Utils/PipeExtensions.cs
Outdated
Show resolved
Hide resolved
src/System.Net.Security/tests/StressTests/SslStress/Utils/PipeExtensions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Nov 13, 2019
| namespace SslStress.Utils | ||
| { | ||
| // Adapted from https://github.com/dotnet/corefx/blob/41cd99d051102be4ed83f4f9105ae9e73aa48b7c/src/Common/tests/System/IO/Compression/CRC.cs | ||
| public static class CRC |
There was a problem hiding this comment.
What adaptation was needed? Why can't we just have a single shared implementation?
There was a problem hiding this comment.
In this case spanification. Note that this comment was copied from the stress project which also added a couple of string methods.
There was a problem hiding this comment.
Can we make the changes to the shared implementation and use the spanified version in the original source as well?
There was a problem hiding this comment.
Yes, but it's unlikely I'll get this done before the cutoff.
stephentoub
reviewed
Nov 13, 2019
src/System.Net.Security/tests/StressTests/SslStress/Utils/CountingStream.cs
Outdated
Show resolved
Hide resolved
ViktorHofer
added
the
* NO MERGE *
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a console application for stress testing the SslStream class. The work somewhat imitates the setup that we already have in the http stress app: the app will open a fixed number of concurrent connections and run the stress scenaria for a fixed time period per connection (defaults at 2 minutes).
Unlike http2 there are no multiplexing concerns here, so the potential for stress tests seems less interesting. I've only included a single scenario for the moment: sending and echoing back of random data with basic integrity checks, using randomized permutations of
Write,WriteAsync,WriteByteandFlushmethods. I haven't been able to reproduce failures so far, though I haven't run the app for extensive periods of time yet.