Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial SslStream stress app work #123

Closed
wants to merge 8 commits into from
Closed

Initial SslStream stress app work #123

wants to merge 8 commits into from

Conversation

eiriktsarpalis
Copy link
Member

Adds the changes initially created for the corefx repo in dotnet/corefx#42560

Adds a console application for stress testing the SslStream class. The work somewhat imitates the setup that we already have in the http stress app: the app will open a fixed number of concurrent connections and run the stress scenaria for a fixed time period per connection (defaults at 2 minutes).

Unlike http2 there are no multiplexing concerns here, so the potential for stress tests seems less interesting. I've only included a single scenario for the moment: sending and echoing back of random data with basic integrity checks, using randomized permutations of Write, WriteAsync, WriteByte and Flush methods. I haven't been able to reproduce failures so far, though I haven't run the app for extensive periods of time yet.

@eiriktsarpalis
Copy link
Member Author

NB I can't request reviews from https://github.com/orgs/dotnet/teams/ncl yet, so I'm adding some of you manually. cc @maryamariyan

@eiriktsarpalis eiriktsarpalis added the tenet-reliability Reliability/stability related issue (stress, load problems, etc.) label Nov 19, 2019
@davidsh davidsh added this to the 5.0 milestone Nov 19, 2019
@davidsh
Copy link
Contributor

davidsh commented Nov 19, 2019

Adds the changes initially created for the corefx repo in dotnet/corefx#42560

Does this PR incorporate the existing feedback/changes from the corefx repo PR which was already reviewed?

@davidsh
Copy link
Contributor

davidsh commented Nov 19, 2019

/azp run corefx-outerloop

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@davidsh
Copy link
Contributor

davidsh commented Nov 19, 2019

/azp list

@davidsh
Copy link
Contributor

davidsh commented Nov 19, 2019

/azp runtime-libraries outerloop

@azure-pipelines
Copy link

Command 'runtime-libraries' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or a specific pipeline for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify a pipeline to run.
    • Example: "run" or "run pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@davidsh
Copy link
Contributor

davidsh commented Nov 19, 2019

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

Does this PR incorporate the existing feedback/changes from the corefx repo PR which was already reviewed?

Mostly yes, with the only outstanding issue being this one. I've been thinking about this, and my conclusion is that I'd prefer it if we didn't reference other test code, at least not until we're not validating the stress projects in CI. Moving forward I would like to consolidate the stress projects into a single solution which are built as part of CI. @stephentoub thoughts?

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member

jkotas commented Nov 23, 2019

FYI: We are discouraging creating PR branches in the dotnet/runtime repo. Could you please create the branch in your fork next time?

https://github.com/dotnet/consolidation/blob/master/Documentation/issues-pr-management.md#what-will-be-dotnetruntimes-branch-policy

@eiriktsarpalis
Copy link
Member Author

@jkotas The branches have been pushed to the main repo deliberately, as it's the only way I can debug the stress pipelines with the changes. I will make sure they are cleaned up as soon as the PRs are merged.

@eiriktsarpalis
Copy link
Member Author

/azp list

@eiriktsarpalis
Copy link
Member Author

/azp list

@eiriktsarpalis
Copy link
Member Author

/azp run runtime-libraries stress-http-windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eiriktsarpalis
Copy link
Member Author

Closing and re-creating as the publication of the repo has caused issues in my personal fork.

@eiriktsarpalis
Copy link
Member Author

Replaced by #290

MichalStrehovsky pushed a commit to MichalStrehovsky/runtime that referenced this pull request Oct 12, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Security tenet-reliability Reliability/stability related issue (stress, load problems, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants