-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial SslStream stress app work #123
Conversation
NB I can't request reviews from https://github.com/orgs/dotnet/teams/ncl yet, so I'm adding some of you manually. cc @maryamariyan |
Does this PR incorporate the existing feedback/changes from the corefx repo PR which was already reviewed? |
/azp run corefx-outerloop |
No pipelines are associated with this pull request. |
/azp list |
/azp runtime-libraries outerloop |
Command 'runtime-libraries' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
/azp run runtime-libraries outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Mostly yes, with the only outstanding issue being this one. I've been thinking about this, and my conclusion is that I'd prefer it if we didn't reference other test code, at least not until we're not validating the stress projects in CI. Moving forward I would like to consolidate the stress projects into a single solution which are built as part of CI. @stephentoub thoughts? |
/azp run runtime-libraries outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Security/tests/StressTests/SslStress/Configuration.cs
Show resolved
Hide resolved
src/libraries/System.Net.Security/tests/StressTests/SslStress/SslStress.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/tests/StressTests/SslStress/global.json
Outdated
Show resolved
Hide resolved
FYI: We are discouraging creating PR branches in the dotnet/runtime repo. Could you please create the branch in your fork next time? |
@jkotas The branches have been pushed to the main repo deliberately, as it's the only way I can debug the stress pipelines with the changes. I will make sure they are cleaned up as soon as the PRs are merged. |
/azp list |
/azp list |
/azp run runtime-libraries stress-http-windows |
Azure Pipelines successfully started running 1 pipeline(s). |
Closing and re-creating as the publication of the repo has caused issues in my personal fork. |
Replaced by #290 |
Merge from dotnet/runtime
Adds the changes initially created for the corefx repo in dotnet/corefx#42560