This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Port optimization in Buffer.Memmove from CoreCLR #3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
approved these changes
May 8, 2017
| @@ -2,6 +2,10 @@ | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
| // See the LICENSE file in the project root for more information. | |||
|
|
|||
| #if AMD64 || (BIT32 && !ARM) | |||
There was a problem hiding this comment.
We don't set BIT32 anywhere. If you think we should set it, you'll need to add it to dir.props at the root and validate it kicks in on the TFS side as well (there's a separate place where we set stuff like BIT64 under ndp\FxCore\dir.settings.targets - it might be redundant or might not, I didn't really look at how those two builds are tangled together).
This is just a copy of changes made in dotnet/coreclr#9786
MichalStrehovsky
approved these changes
May 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a copy of changes made in dotnet/coreclr#9786.
On my machine I see about 5% improvement in a micro-benchmark.