Add support for GC static fields #44

MichalStrehovsky · 2015-10-09T02:24:53Z

Expose GC static size and alignment from MetadataType
Add __assignReference JIT helper
Emit GC static data section into the assembly file

jkotas · 2015-10-09T02:39:53Z

src/ILToNative/src/Compiler/AsmWriter.cs

+ void OutputJitHelpers()
+ {
+ // assignReference is always the same. This will be a call into the runtime.
+ Out.WriteLine("__assignReference:");


This should just call WriteBarrier - maybe copy the implementation from Native\gc\sample\GCSample.cpp to the "repro" project until we get the right implementation from MRT?

jkotas · 2015-10-12T21:41:10Z

(Maybe there are better names AsmWriter.EEType.cs, EEType.AsmWriter.cs ... not sure.)

* Expose GC static size and alignment from MetadataType * Add __assignReference JIT helper * Emit GC static data section into the assembly file

We were previously allocating the GC static region statically in the image, but for Ready to Run, we will require GC static regions to be allocated on the GC heap.

Add support for GC static fields

jkotas reviewed Oct 9, 2015
View reviewed changes

MichalStrehovsky added 2 commits October 12, 2015 16:11

Add support for GC static fields

2aa5004

* Expose GC static size and alignment from MetadataType * Add __assignReference JIT helper * Emit GC static data section into the assembly file

Allocate GC statics on the GC heap

3778479

We were previously allocating the GC static region statically in the image, but for Ready to Run, we will require GC static regions to be allocated on the GC heap.

MichalStrehovsky added a commit that referenced this pull request Oct 12, 2015

Merge pull request #44 from MichalStrehovsky/GCStatics

b01f36c

Add support for GC static fields

MichalStrehovsky merged commit b01f36c into dotnet:master Oct 12, 2015

MichalStrehovsky deleted the GCStatics branch October 12, 2015 23:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for GC static fields #44

Add support for GC static fields #44

MichalStrehovsky commented Oct 9, 2015

jkotas Oct 9, 2015

jkotas commented Oct 12, 2015

Add support for GC static fields #44

Add support for GC static fields #44

Conversation

MichalStrehovsky commented Oct 9, 2015

jkotas Oct 9, 2015

Choose a reason for hiding this comment

jkotas commented Oct 12, 2015