Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Use canonical method IL in scanner's ImportCall #5686

Merged
merged 2 commits into from
Apr 12, 2018

Conversation

MichalStrehovsky
Copy link
Member

This is necessary so that the scanner can accurately predict what weird things we're going to need later. We're emulating what getCallInfo will do.

Fixes #5648. Note that the F# hello app is still blocked, this time on complex tail calls (#1683).

@MichalStrehovsky MichalStrehovsky merged commit 657a366 into dotnet:master Apr 12, 2018
@MichalStrehovsky MichalStrehovsky deleted the fixFsharp branch April 12, 2018 20:10
@charlesroddie
Copy link
Contributor

@MichalStrehovsky "The F# hello app is still blocked, this time on complex tail calls." Have you confirmed that? I would not have expected simple apps like hello world, or even most real-world F# apps, to be blocked by complex tail calls.

@MichalStrehovsky
Copy link
Member Author

It was blocked, but Jan subsequently made a fix to RyuJIT that unblocked it (dotnet/coreclr#17592, followed by #5712).

I think it means we still can't do complex tailcalls, but fewer tailcalls are considered complex.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants