This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
Switch to live CLI build #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @schellap |
|
@dotnet-bot test this please |
|
@yishaigalatzer, can someone take a look from your team? NuGet v3 restore causes the below error consistently as part of build on our CI machines. This is blocking us from adopting v3 and the iterate on changes to CLI and CoreRT. I can share the ssh credentials to the dev. |
|
This issue may be fixed in NuGet xplat 605 and up. There was a race case where restores were running in parallel and deleting all files in a shared the temp folder. A workaround for this would be to use dotnet restore |
|
@dotnet-bot test this please |
| @@ -172,7 +172,7 @@ if "%__CleanBuild%"=="1" ( | |||
| ) | |||
|
|
|||
| if not exist "%__DotNetCliPath%" ( | |||
| for /f "delims=" %%a in ('powershell -NoProfile -ExecutionPolicy RemoteSigned "& "%__SourceDir%\scripts\install-cli.ps1" -installdir "%__RootBinDir%\tools" -version "1.0.0.000973""') do ( | |||
| for /f "delims=" %%a in ('powershell -NoProfile -ExecutionPolicy RemoteSigned "& "%__SourceDir%\scripts\install-cli.ps1" -installdir "%__RootBinDir%\tools""') do ( | |||
| echo "" > nul | |||
| ) | |||
| ) | |||
There was a problem hiding this comment.
@jkotas could you please add above the :SetupManagedBuild, should help in pinning LKG.
echo type "%__DotNetCliPath%\.version"
type "%__DotNetCliPath%\.version"
jkotas
added a commit
to jkotas/runtimelab
that referenced
this pull request
Sep 13, 2020
MichalStrehovsky
pushed a commit
to dotnet/runtimelab
that referenced
this pull request
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains rollback all fixes required to switch to live CLI build. We can use it to check whether all issues in live CLI build has been resolved.