Skip to content

Conversation

@nxtn
Copy link
Contributor

@nxtn nxtn commented Mar 10, 2019

Fixes dotnet/docs#11067

int -> IntPtr for HANDLE
int -> UIntPtr for SIZE_T

BTW the coding styles in this repo are terrible.

/cc @Thraka @BillWagner

@nxtn nxtn mentioned this pull request Mar 18, 2019
@nxtn
Copy link
Contributor Author

nxtn commented Apr 14, 2019

@BillWagner Can you review this?

@mairaw
Copy link
Contributor

mairaw commented Oct 9, 2019

@gafter @jcouv would you be the right people to review this?

@BillWagner
Copy link
Member

@mairaw

I've got primary responsibility on these now. I'll pull in others if needed for further review.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates @NextTurn We appreciate it.

I've reviewed everything, and I'll approve this. I'm checking with others before we merge this though.

We 're working with ECMA to update the standard. The version published here needs to be reconciled with the 5.0 standard. We want to avoid further divergence between those two versions. The sections updated in this PR are not present in the ECMA 5.0 standard. For that reason, I believe this should be merged: It won't increase the committee's work reconciling the versions. It will decrease work validating new content, because this PR does fix errors in the code sample.

/cc @gafter @MadsTorgersen

@gafter gafter merged commit a5e393b into dotnet:master Oct 14, 2019
@nxtn nxtn deleted the patch-1 branch October 14, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

array

4 participants